Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build for gfsv17 test to use -D32BIT=ON and set fewer tests for S4 #1728

Merged

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Apr 26, 2023

Description

Move cpld_control_gfsv17 to -D32BIT=ON build section as GFSv17 will use this option. Description of the evaluation by @LydiaStefanova-NOAA can be found here comparing -D32BIT=ON vs OFF for HR1 runss.

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests: cpld_control_gfsv17

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@JessicaMeixner-NOAA JessicaMeixner-NOAA added the Baseline Updates Current baselines will be updated. label Apr 26, 2023
@JessicaMeixner-NOAA
Copy link
Collaborator Author

No changes in gnu baseline, log:
RegressionTests_hera.gnu.log

Comparing against new baseline for intel, log:
RegressionTests_hera.intel.log

@BrianCurtis-NOAA
Copy link
Collaborator

Will this change allow the test to be successful on wcoss2.intel ?

@BrianCurtis-NOAA BrianCurtis-NOAA added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label May 3, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

@JessicaMeixner-NOAA please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • fv3 NOT up to date
  • ww3 NOT up to date

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Will this change allow the test to be successful on wcoss2.intel ?

Unsure, I will test and let you know.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@BrianCurtis-NOAA it is successful on WCOSS2 now. I just ran the 2 32bit tests and they matched the baseline that I created. I'm happy to share paths if needed.

@BrianCurtis-NOAA
Copy link
Collaborator

Thanks! Can you update rt.conf enabling wcoss2.intel for that test?

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Thanks! Can you update rt.conf enabling wcoss2.intel for that test?

@BrianCurtis-NOAA I think it's enabled by moving it to the other compile section already, but if I'm missing something here let me know, I'm happy to update this.

tests/rt.conf Outdated Show resolved Hide resolved
@JessicaMeixner-NOAA
Copy link
Collaborator Author

@BrianCurtis-NOAA tested on wcoss2 and updated rt.conf

@jkbk2004
Copy link
Collaborator

@JessicaMeixner-NOAA We can start working on this pr. Can you sync up? #1701 contains a minor update on rt.conf. It will be great to combine #1701 into this pr. @DavidHuber-NOAA can you create a direct pr to Jessica's branch?

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Branch is updated @jkbk2004

@jkbk2004 jkbk2004 mentioned this pull request May 15, 2023
19 tasks
@jkbk2004 jkbk2004 added hera-gnu-RT jenkins-ci Jenkins CI: ORT build/test on docker container and removed hera-gnu-RT labels May 16, 2023
@jkbk2004 jkbk2004 changed the title Update build for gfsv17 test to use -D32BIT=ON Update build for gfsv17 test to use -D32BIT=ON and set few tests for S4 May 16, 2023
@jkbk2004 jkbk2004 changed the title Update build for gfsv17 test to use -D32BIT=ON and set few tests for S4 Update build for gfsv17 test to use -D32BIT=ON and set fewer tests for S4 May 16, 2023
@zach1221
Copy link
Collaborator

Jenkins-ci logs attached, ORTs passed.
ufs-weather-model » ort-docker-pipeline » PR-1728 #2 Console [Jenkins].pdf

@BrianCurtis-NOAA
Copy link
Collaborator

WCOSS2 in maintenance mode. Acorn had a hardware failure on their ecflow node so i can't finish RT's, but baselines are done. Please skip both.

@jkbk2004
Copy link
Collaborator

Ok! We can start merging this pr. Please, go ahead for final reviews and approvals.

@jkbk2004 jkbk2004 removed the jenkins-ci Jenkins CI: ORT build/test on docker container label May 16, 2023
@jkbk2004 jkbk2004 merged commit 2cf2227 into ufs-community:develop May 16, 2023
@jkbk2004 jkbk2004 mentioned this pull request May 16, 2023
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the feature/gfsv17test32bit branch May 18, 2023 21:09
@Qingfu-Liu Qingfu-Liu mentioned this pull request May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants