Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dycore semi-implicit solver update #1720

Merged
merged 14 commits into from
Apr 28, 2023

Conversation

XiaqiongZhou-NOAA
Copy link
Contributor

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA commented Apr 24, 2023

Description

To bring semi-implicit solver update in dynamics to UFS. A new baseline should be created since it will change the results.

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
    all regression tests.

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA marked this pull request as ready for review April 24, 2023 13:52
@XiaqiongZhou-NOAA XiaqiongZhou-NOAA changed the title dycore semi-implicit solve update dycore semi-implicit solver update Apr 24, 2023
@XiaqiongZhou-NOAA XiaqiongZhou-NOAA changed the title dycore semi-implicit solver update Dycore semi-implicit solver update Apr 24, 2023
@BrianCurtis-NOAA BrianCurtis-NOAA added the Baseline Updates Current baselines will be updated. label Apr 24, 2023
@jkbk2004
Copy link
Collaborator

@XiaqiongZhou-NOAA sounds like fv3 dependency PR was tested on wcoss2. If test result (log file) is attached to the pr, it will speed up the commit process. I mean if available. Either way, we will use jenkins-ci as pre-test.

@XiaqiongZhou-NOAA
Copy link
Contributor Author

I have merged latest UFS to my branch and will rerun the regression tests to create a new baseline on wcoss2.
Please let me know if there are anything else I can do.

@jkbk2004
Copy link
Collaborator

@XiaqiongZhou-NOAA hold a bit. We are working on #1509. You may try to re-run after #1509 is merged, We can help to re-run on Cheyenne.

@XiaqiongZhou-NOAA
Copy link
Contributor Author

XiaqiongZhou-NOAA commented Apr 26, 2023 via email

@jkbk2004
Copy link
Collaborator

Sure! We still have time. We will help to test on Cheyenne while jenkin-ci runs. Hera scratch1 disk quota issue this morning. I am trying to clean up a bit. I will keep you posted.

@jkbk2004
Copy link
Collaborator

@XiaqiongZhou-NOAA We can start working on this pr. #1509 was merged. Can you sync up?

@XiaqiongZhou-NOAA
Copy link
Contributor Author

Synced

@jkbk2004 jkbk2004 added Waiting for Reviews The PR is waiting for reviews from associated component PR's. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ci Jenkins CI: ORT build/test on docker container labels Apr 26, 2023
@jkbk2004
Copy link
Collaborator

@XiaqiongZhou-NOAA
Copy link
Contributor Author

@XiaqiongZhou-NOAA
Copy link
Contributor Author

"Test 008 compile FAIL" in cheyenne.intel.log. Any issues there?

@jkbk2004
Copy link
Collaborator

"Test 008 compile FAIL" in cheyenne.intel.log. Any issues there?

cpld_control_p8_faster was turned off on cheyenne. I think we should turn off the 008 build on cheyenne as well.

@zach1221
Copy link
Collaborator

@jkbk2004 cpld_control_nowave_noaero_p8 failed the ORT debug test, when running jenkins-ci against this PR. Everything else passed. I'll look into the failure.

@jkbk2004
Copy link
Collaborator

@zach1221 we need a decision about jenkins-ci cpld_control_nowave_noaero_p8. Can you give a try to run ort cpld_control_nowave_noaero_p8 on here or hera?

@zach1221
Copy link
Collaborator

@jkbk2004 Yes, I'll test again on Hera now.

@zach1221
Copy link
Collaborator

@jkbk2004 cpld_control_nowave_noaero_p8 passed ORTs using both intel/gnu compilers on Hera.

@jkbk2004
Copy link
Collaborator

all test are done. we can start merging process. thanks @zach1221 for following with ORT.

@jkbk2004
Copy link
Collaborator

@XiaqiongZhou-NOAA fv3 pr was merged. Can you update hash and revert change in gitmodules? correct hash is NOAA-EMC/fv3atm@e0d95b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. jenkins-ci Jenkins CI: ORT build/test on docker container Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants