MYNN surface Layer Upate

[joeolson42]

MYNN surface-layer scheme update:

Updates from RRFS_dev, which include updates made for RRFS "Base E" (negligible impact on forecasts beyond the first 10 or so timesteps) + some addition mods below:

• Reintroduce u* averaging over water, which can help reduce the noisy 10-m winds in the hurricane regime. This has little or no impact in any other regime.
• Clean-up of the model constants. There was actually a benign bug found with a constant coming in from the interface AND the "use phys_constants". Also, g was defined globally and in some subroutines. This can be further cleaned up later, but this takes out all known issues.
• Changed "kind=kind_phys" to just "kind_phys", which was requested in a previous PR.
• Updated some comments that were out of date.

Top of commit queue on: TBD

Input data additions/changes

• No changes are expected to input data.
• There will be new input data.
• Input data will be updated.

Anticipated changes to regression tests:

• No changes are expected to any regression test.
• Changes are expected to the following tests: any configuration that runs the MYNN surface layer scheme

Subcomponents involved:

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Combined with PR's (If Applicable):

This may be combined with the RUC LSM PR

Commit Queue Checklist:

• Link PR's from all sub-components involved
• Confirm reviews completed in sub-component PR's
• Add all appropriate labels to this PR.
• Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
• Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

• Depends on Updates to the MYNN surface-layer scheme ccpp-physics#58
• Depends on update submodule pointer for ccpp-physics for MYNN surface layer PR NOAA-EMC/fv3atm#640

Testing Day Checklist:

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
• Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

• RDHPCS
  • Intel
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • GNU
    • Hera
    • Cheyenne
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[SamuelTrahanNOAA]

@jkbk2004 - Apparently this also needs to be merged before the end of April. Is there a way to make that happen?

[jkbk2004]

We have a flexibility for the rest of the week. It's likely to work on the combined PRs #1660 + #1646 today or tomorrow, right? If we let the combined PRs go today, we still have time for this pr either tomorrow or Friday. If you like to combine all 3 PRs together, that's still possible and we can schedule like tomorrow to give enough time for pre-test. #1672 is on-going. I think it will be merged this afternoon.

[SamuelTrahanNOAA]

I'll work on merging #1678 into #1646

[joeolson42]

The gnu tests look ok. I'm running the intel tests now (on hera). Will upload results later today. Sam, thanks for doing the merge.

…

-joe

On Wed, Mar 29, 2023 at 7:55 AM Samuel Trahan (NOAA contractor) < ***@***.***> wrote: I'll work on merging #1678 <#1678> into #1646 <#1646> — Reply to this email directly, view it on GitHub <#1678 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADLRR3W3QBKUAWEVI2WGDXTW6Q5MFANCNFSM6AAAAAAWG6WJP4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Joseph Olson Model Physics Branch Chief Environmental Prediction Advancement Division NOAA-Global Systems Laboratory Boulder, Colorado

[jkbk2004]

@SamuelTrahanNOAA #1672 was merged. Let me know if you want us to wait for #1646 (combined with this one and #1660) to be ready. Or we can go for another pr #1685 for minor change on cmeps and ww3. @zach1221 FYI

[SamuelTrahanNOAA]

You should commit #1646 next. I am working on updating it right now.

[SamuelTrahanNOAA]

I have updated #1646; it is up-to-date with develop. Also, my tests of the combination of 1660+1646+1678 passed on hera.intel and hera.gnu before I merged 1672. The Jet tests are still running, but it is extremely rare for the tests to pass on hera.intel and fail on jet.intel.

[jkbk2004]

Merged with #1646