Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type mismatch compiler error when gfortran 10 is used without '-fallow-argument-mismatch' flag #1147

Merged
merged 113 commits into from
Mar 20, 2024
Merged
Show file tree
Hide file tree
Changes from 108 commits
Commits
Show all changes
113 commits
Select commit Hold shift + click to select a range
b5ab330
Update .gitmodules
DusanJovic-NOAA Mar 23, 2022
3e445e2
Resolve argument mismatch errors when using gfortran
DusanJovic-NOAA Mar 24, 2022
50cef09
Update FV3
DusanJovic-NOAA Mar 29, 2022
4be4e0e
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Mar 29, 2022
1874364
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Apr 8, 2022
1b04fb6
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA May 13, 2022
eef2070
Update FV3
DusanJovic-NOAA Jun 14, 2022
5feb519
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Jun 14, 2022
47f446b
update FV3
DusanJovic-NOAA Jul 5, 2022
58f5fbb
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Jul 5, 2022
c949167
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Jul 13, 2022
65ef6f8
update FV3
DusanJovic-NOAA Jul 19, 2022
1fcbe29
update stochastic_physics
DusanJovic-NOAA Jul 19, 2022
1c5b6ad
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Jul 19, 2022
65df0f1
update FV3
DusanJovic-NOAA Jul 19, 2022
dc8a5fc
update FV3
DusanJovic-NOAA Jul 20, 2022
489297c
update FV3
DusanJovic-NOAA Aug 10, 2022
cc90bd7
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Aug 10, 2022
4c2cf8c
Update FV3
DusanJovic-NOAA Sep 28, 2022
b9744af
Update stochastic_physics
DusanJovic-NOAA Sep 28, 2022
865d7e5
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Sep 28, 2022
4d8cee7
update FV3
DusanJovic-NOAA Sep 28, 2022
28919f1
Update FV3
DusanJovic-NOAA Oct 13, 2022
68d9f84
Merge branch 'develop' into no_arg_mismatch
DusanJovic-NOAA Oct 13, 2022
4520d99
Update FV3
DusanJovic-NOAA Oct 17, 2022
e6a0fdd
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Oct 17, 2022
fd8b682
Update FV3
DusanJovic-NOAA Nov 7, 2022
209d603
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Nov 7, 2022
16e6ec0
Update submodule pointer for CMakeModules
climbfuji Nov 7, 2022
b662de2
Update .gitmodules and submodule pointer for FV3
climbfuji Nov 7, 2022
63f9b1b
Also find shared PIO libraries
climbfuji Nov 7, 2022
2a000bc
Update modulefiles/ufs_cheyenne.gnu.lua, modulefiles/ufs_cheyenne.gnu…
climbfuji Nov 7, 2022
5dee80d
Remove lmod reinit for Cheyenne in tests/module-setup.sh
climbfuji Nov 7, 2022
fd999ae
Merge branch 'no_arg_mismatch' of https://github.com/dusanjovic-noaa/…
climbfuji Nov 7, 2022
5204f2f
Changes to tests/compile.sh tests/module-setup.sh for cheyenne.gnu wi…
climbfuji Nov 7, 2022
78e495e
Update FV3
DusanJovic-NOAA Nov 7, 2022
6e6c5ae
Merge branch 'no_arg_mismatch' of https://github.com/dusanjovic-noaa/…
climbfuji Nov 7, 2022
08e3b4c
Revert .gitmodules
climbfuji Nov 8, 2022
67a0206
Update ecflow on Cheyenne for rt.sh
climbfuji Nov 8, 2022
ba9b6e0
Remove executable permission from tests/fv3_conv/fv3_qsub.IN_cheyenne
climbfuji Nov 8, 2022
cabc22f
Update FV3
DusanJovic-NOAA Nov 8, 2022
4f840c6
update FV3
DusanJovic-NOAA Nov 18, 2022
250d17a
Update FV3
DusanJovic-NOAA Dec 15, 2022
3c887ef
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Dec 15, 2022
93b7ce1
Update FV3 and stochastic_physics
DusanJovic-NOAA Dec 30, 2022
98da0fb
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Dec 30, 2022
63d2df7
Update FV3
DusanJovic-NOAA Mar 16, 2023
23bf02e
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Mar 16, 2023
2178455
Update FV3
DusanJovic-NOAA Mar 16, 2023
f2e809b
Update FV3
DusanJovic-NOAA Mar 29, 2023
ce03c93
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Mar 29, 2023
a8d6ad4
Update FV3
DusanJovic-NOAA Mar 30, 2023
63753a8
Update FV3
DusanJovic-NOAA Apr 26, 2023
2e859d6
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Apr 26, 2023
93806a6
Print MPI Library version in the main program
DusanJovic-NOAA Apr 26, 2023
dcfa818
Update FV3
DusanJovic-NOAA May 4, 2023
c1b09bb
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA May 4, 2023
da77c36
Update FV3
DusanJovic-NOAA Jun 8, 2023
16f4111
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Jun 8, 2023
840a013
Update FV3
DusanJovic-NOAA Jun 13, 2023
da83592
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Jun 13, 2023
a1e8e36
Update FV3
DusanJovic-NOAA Aug 4, 2023
056e1ca
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Aug 4, 2023
58762d9
Update FV3
DusanJovic-NOAA Aug 28, 2023
21915c3
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Aug 28, 2023
ae6dfab
Update FV3
DusanJovic-NOAA Sep 6, 2023
f73ca62
Update stochastic_physics
DusanJovic-NOAA Sep 6, 2023
5936f71
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Sep 6, 2023
07c9e69
Update FV3
DusanJovic-NOAA Sep 15, 2023
7751377
Update stochastic_physics
DusanJovic-NOAA Sep 15, 2023
7ac2826
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Sep 15, 2023
80c1492
Update ufs_cheyenne.gnu.lua
DusanJovic-NOAA Sep 18, 2023
5c58f05
Update compile.sh and module-setup.sh from develop
DusanJovic-NOAA Sep 19, 2023
0e0551e
Update FV3
DusanJovic-NOAA Nov 1, 2023
504c2af
Update stochastic_physics
DusanJovic-NOAA Nov 1, 2023
9609ef8
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Nov 1, 2023
fd8863d
Update FV3
DusanJovic-NOAA Nov 3, 2023
3219a3f
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Nov 3, 2023
1319cf0
Update FV3
DusanJovic-NOAA Nov 3, 2023
513d042
Update FV3
DusanJovic-NOAA Dec 18, 2023
dfd78c0
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Dec 18, 2023
d680eab
Update FV3
DusanJovic-NOAA Jan 4, 2024
884961f
Update stochastic_physics
DusanJovic-NOAA Jan 4, 2024
fedd9fe
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Jan 4, 2024
c08b7f9
Update FV3 and stochastic_physics
DusanJovic-NOAA Jan 16, 2024
7297471
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Jan 16, 2024
7967de0
Update FV3
DusanJovic-NOAA Jan 19, 2024
097b050
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Jan 19, 2024
0b4dc0f
Update FV3
DusanJovic-NOAA Feb 7, 2024
fb0f4fc
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Feb 7, 2024
bc30ad3
Update FV3
DusanJovic-NOAA Feb 7, 2024
b9f0c3e
Update FV3
DusanJovic-NOAA Feb 7, 2024
4ae108c
Update FV3
DusanJovic-NOAA Feb 26, 2024
44dcfc6
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Feb 26, 2024
cca412e
Update FV3
DusanJovic-NOAA Feb 27, 2024
1d0e135
Update FV3
DusanJovic-NOAA Mar 18, 2024
ba1d11b
Merge remote-tracking branch 'origin/develop' into no_arg_mismatch
DusanJovic-NOAA Mar 18, 2024
159c8a9
Regression test passed on Hera
DusanJovic-NOAA Mar 18, 2024
166605b
Update FV3
DusanJovic-NOAA Mar 19, 2024
2b2e99f
Update repo_check.sh: turn off upp check
jkbk2004 Mar 19, 2024
879e687
Merge branch 'no_arg_mismatch' of https://github.com/DusanJovic-NOAA/…
DusanJovic-NOAA Mar 19, 2024
5e70cd6
[AutoRT] Hercules Job Failed!
epic-cicd-jenkins Mar 19, 2024
7908de2
Merge branch 'no_arg_mismatch' of github.com:DusanJovic-NOAA/ufs-weat…
epic-cicd-jenkins Mar 19, 2024
b91a8c1
Update repo_check.sh: fix path and branch names
jkbk2004 Mar 19, 2024
a0c8f70
WCOSS2 RT Log: Pass
BrianCurtis-NOAA Mar 19, 2024
a1fbd3d
add hercules RT logs: passed
zach1221 Mar 19, 2024
3271aa5
add dereco RT logs: passed
zach1221 Mar 19, 2024
889b350
add orion RT logs: passed
zach1221 Mar 19, 2024
6b6625a
[AutoRT] Gaea Job Completed.
epic-cicd-jenkins Mar 19, 2024
7842b88
Delete tests/logs/RT-run-Hercules.log
zach1221 Mar 19, 2024
bce9e3d
Delete tests/logs/RT-run-Orion.log
zach1221 Mar 19, 2024
1ea32ad
add jet RT logs: passed
zach1221 Mar 19, 2024
c9e0b9b
Revert .gitmodules and update FV3 and stochastic_physics
DusanJovic-NOAA Mar 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
[submodule "FV3"]
path = FV3
url = https://github.com/NOAA-EMC/fv3atm
branch = develop
#url = https://github.com/NOAA-EMC/fv3atm
#branch = develop
url = https://github.com/DusanJovic-NOAA/fv3atm
branch = no_arg_mismatch
[submodule "WW3"]
path = WW3
url = https://github.com/NOAA-EMC/WW3
branch = dev/ufs-weather-model
[submodule "stochastic_physics"]
path = stochastic_physics
url = https://github.com/NOAA-PSL/stochastic_physics
branch = master
#url = https://github.com/NOAA-PSL/stochastic_physics
#branch = master
url = https://github.com/DusanJovic-NOAA/stochastic_physics
branch = no_arg_mismatch
[submodule "CMakeModules"]
path = CMakeModules
url = https://github.com/NOAA-EMC/CMakeModules
Expand Down
4 changes: 0 additions & 4 deletions cmake/GNU.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ endif()

set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -ggdb -fbacktrace -cpp -fcray-pointer -ffree-line-length-none -fno-range-check")

if(${CMAKE_Fortran_COMPILER_VERSION} VERSION_GREATER_EQUAL 10)
set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fallow-argument-mismatch -fallow-invalid-boz")
endif()

if(NOT 32BIT)
set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fdefault-real-8 -fdefault-double-8")
endif()
Expand Down
10 changes: 9 additions & 1 deletion driver/UFS.F90
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ PROGRAM UFS
TYPE(ESMF_Config) :: CF_MAIN !<-- The Configure object
!
CHARACTER(ESMF_MAXSTR) :: MESSAGE_CHECK
!
CHARACTER(len=MPI_MAX_LIBRARY_VERSION_STRING) :: library_version
INTEGER :: resultlen
!
INTEGER :: RC, RC_USER !<-- The running error signal
!
Expand Down Expand Up @@ -122,7 +125,12 @@ PROGRAM UFS
!*** Print subversion version and other status information.
!-----------------------------------------------------------------------
!
if (mype==0) call w3tagb('ufs ',0000,0000,0000,'np23 ')
if (mype == 0) then
call w3tagb('ufs-weather-model',0,0,0,'np23')
call MPI_Get_library_version(library_version, resultlen, rc)
write(*,'(A,A)') 'MPI Library = ', library_version(1:resultlen)
write(*,'(A,I0,A,I0)')'MPI Version = ', mpi_version,'.',mpi_subversion
endif
!
!-----------------------------------------------------------------------
!*** Set up the default log.
Expand Down
20 changes: 10 additions & 10 deletions tests/ci/repo_check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ result() {
}

# Declare variables
declare -A base fv3 mom6 cice ww3 stoch gocart cmeps cdeps hycom cmake ccpp-framework ccpp-physics upp atmos_cubed_sphere
submodules="fv3 mom6 cice ww3 stoch gocart cmeps cdeps hycom cmake ccpp-framework ccpp-physics upp atmos_cubed_sphere"
declare -A base fv3 mom6 cice ww3 stoch gocart cmeps cdeps hycom cmake ccpp-framework ccpp-physics atmos_cubed_sphere
submodules="fv3 mom6 cice ww3 stoch gocart cmeps cdeps hycom cmake ccpp-framework ccpp-physics atmos_cubed_sphere"
comment=''
ownerID=$1

Expand Down Expand Up @@ -44,7 +44,7 @@ stoch[branch]='master'
stoch[dir]='stochastic_physics'

gocart[repo]='https://github.com/GEOS-ESM/GOCART'
gocart[branch]='main'
gocart[branch]='develop'
gocart[dir]='GOCART'

cmeps[repo]='https://github.com/NOAA-EMC/CMEPS'
Expand All @@ -65,19 +65,19 @@ cmake[dir]='CMakeModules'

ccpp-framework[repo]='https://github.com/NCAR/ccpp-framework'
ccpp-framework[branch]='main'
ccpp-framework[dir]='ccpp/framework'
ccpp-framework[dir]='FV3/ccpp/framework'

ccpp-physics[repo]='https://github.com/ufs-community/ccpp-physics'
ccpp-physics[branch]='ufs/dev'
ccpp-physics[dir]='ccpp/physics'
ccpp-physics[dir]='FV3/ccpp/physics'

upp[repo]='https://github.com/NOAA-EMC/UPP'
upp[branch]='develop'
upp[dir]='upp'
#upp[repo]='https://github.com/NOAA-EMC/UPP'
#upp[branch]='develop'
#upp[dir]='upp'

atmos_cubed_sphere[repo]='https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere'
atmos_cubed_sphere[branch]='main'
atmos_cubed_sphere[dir]='atmos_cubed_sphere'
atmos_cubed_sphere[branch]='dev/emc'
atmos_cubed_sphere[dir]='FV3/atmos_cubed_sphere'

# Get sha-1's of the top of develop of ufs-weather-model
app="Accept: application/vnd.github.v3+json"
Expand Down
Loading
Loading