Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORT script failure due to TASK-related variable changes #1586

Closed
zach1221 opened this issue Jan 26, 2023 · 3 comments · Fixed by #1596
Closed

ORT script failure due to TASK-related variable changes #1586

zach1221 opened this issue Jan 26, 2023 · 3 comments · Fixed by #1596
Labels
bug Something isn't working

Comments

@zach1221
Copy link
Collaborator

zach1221 commented Jan 26, 2023

Description

On tier one HPCs Hera and Orion, the operational requirement script fails with the below error.
"/ufs-weather-model/tests/opnReqTests/std.sh: line 34: TASKS: unbound variable Died with error code 1"

Expected behavior is that ORT should run successfully and pass ORT tests.

To Reproduce:

  1. Log into Hera or Orion
  2. cd into working directory
  3. run git clone of ufs-community/ufs-weather-model develop branch
  4. cd into ufs-weather-model/tests
  5. run ./opnReqTest -n control_p8 -c std

Additional context

This error was also produced by running cases regional_control and cpld_control_nowave_noaero_p8. As well as with all ORT tests std,thr, mpi, dcp, rst, bit, dbg

The issue was possibly created by PR #1523 as there were changes to TASK-related variables from 1523. ORT script update is needed to reflect the change introduced from #1523.

image

@zach1221 zach1221 added the bug Something isn't working label Jan 26, 2023
@jkbk2004
Copy link
Collaborator

@zach1221 can you provide error messages?

@zach1221
Copy link
Collaborator Author

@jkbk2004 I did but my content isnt showing above. You see it if you select edit.

@zach1221
Copy link
Collaborator Author

Hi, @DusanJovic-NOAA

We discovered an issue with running ORT scripts on hera/orion, mentioned above. We believe the error is caused by changes made to TASKS variables in PR #1523 . To account for these updates, I tested removing TASKS variables from opnReqTest, wrt_env.sh, dbg.sh, dcp.sh, mpi.sh, rst.sh, std.sh, thr.sh and the below tests pass successfully.

regional_control std,bit,dcp,thr
cpld_control_nowave_noaero_p8 std,bit,dbg,dcp,rst,thr
control_p8 std,bit,dbg,dcp,fhz,mpi,rst,thr

However, we'd like to get your input on this as well, before committing any changes. Are there any other updates we should make to other files that may impact ORT? If useful, I can post the updates I made while testing.

@zach1221 zach1221 linked a pull request Feb 9, 2023 that will close this issue
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants