Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for cloud effective radius for convective clouds (HR1) #1582

Merged
merged 13 commits into from
Jan 30, 2023
Merged

Bug fix for cloud effective radius for convective clouds (HR1) #1582

merged 13 commits into from
Jan 30, 2023

Conversation

ChunxiZhang-NOAA
Copy link
Contributor

@ChunxiZhang-NOAA ChunxiZhang-NOAA commented Jan 25, 2023 •
edited by BrianCurtis-NOAA
Loading

Description

This is an emergency bug fix for cloud effective radius for convective clouds in ccpp-physics (Issuehttps://github.com/ufs-community/ccpp-physics/issues/36).

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

All cpld and control_p8 related PRs failed as expected.
RegressionTests_hera.intel.log

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Dependencies:

Issue:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@ChunxiZhang-NOAA ChunxiZhang-NOAA marked this pull request as ready for review January 26, 2023 17:13
@jkbk2004
Copy link
Collaborator

With an urgency of this pr, I will start testing while we collect the reviews. @ChunxiZhang-NOAA I am adding new BL_DATE.

@jkbk2004 jkbk2004 added Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. hera-gnu-BL labels Jan 26, 2023
@epic-cicd-jenkins
[AutoRT] cheyenne.gnu Job Completed.
155f51f 
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: BL
Repo location: /glade/scratch/epicufsrt/autort/jenkins/autort/pr/1217200031/20230126114209/ufs-weather-model
Please manually delete: /glade/scratch/epicufsrt/FV3_RT/rt_60961
Test hafs_regional_atm_ocn 082 failed in run_test failed
Test hafs_regional_atm_wav 083 failed in run_test failed
Test hafs_regional_atm_ocn_wav 084 failed in run_test failed
Test hafs_regional_1nest_atm 085 failed in run_test failed
Test hafs_regional_telescopic_2nests_atm 086 failed in run_test failed
Test hafs_global_multiple_4nests_atm 088 failed in run_test failed
Test hafs_regional_storm_following_1nest_atm_ocn 091 failed in run_test failed
Test hafs_regional_docn 094 failed in run_test failed
Test hafs_regional_docn_oisst 095 failed in run_test failed
Test hafs_regional_datm_cdeps 096 failed in run_test failed
Test control_p8_atmlnd_sbs 110 failed in run_test failed
Test atmaero_control_p8 112 failed in run_test failed
Test atmaero_control_p8_rad 113 failed in run_test failed
Test atmaero_control_p8_rad_micro 114 failed in run_test failed
Test regional_atmaq 115 failed in run_test failed
Test regional_atmaq_debug 116 failed in run_test failed
Test compile_019 failed in run_compile failed
Please make changes and add the following label back: cheyenne-intel-BL

@BrianCurtis-NOAA
[AutoRT] orion.intel Job Completed.
98fd800 
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@jkbk2004
Copy link
Collaborator

@ChunxiZhang-NOAA ORT issue was from #1523 We need to update ORT script. @zach1221 is going to create issue. And hopefully we can keep moving with the pr.

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: RT
[RT] Repo location: /glade/scratch/epicufsrt/autort/jenkins/autort/pr/1217200031/20230126154209/ufs-weather-model
Please make changes and add the following label back: cheyenne-intel-RT

@jkbk2004
Copy link
Collaborator

sounds like there is epicufsrt diskquota issue on cheyenne

@zach1221
Copy link
Collaborator

ORT issue opened here #1586

@BrianCurtis-NOAA
[AutoRT] gaea.intel Job Completed.
138ce4d 
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@BrianCurtis-NOAA
[AutoRT] jet.intel Job Completed.
a71e99b 
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: RT
[RT] Repo location: /glade/scratch/epicufsrt/autort/jenkins/autort/pr/1217200031/20230126175717/ufs-weather-model
[RT] Error: Test regional_atmaq_debug 151 failed in run_test failed
Please make changes and add the following label back: cheyenne-intel-RT

@jkbk2004
Copy link
Collaborator

@BrianCurtis-NOAA @SadeghTabas-NOAA RDHPCS tests are done. ORT issue should be addressed in separate PR. This PR can move on for merging after wcoss2 tests.

@BrianCurtis-NOAA
Copy link
Collaborator

I haven't had a chance to run on WCOSS2. It's not available today until maybe 3PM. If that's too late, let me know.

@jkbk2004
Copy link
Collaborator

@ChunxiZhang-NOAA if ok, we can plan to merge by Monday morning ?

@ChunxiZhang-NOAA
Copy link
Contributor Author

@jkbk2004 I can merge it in early Monday afternoon.

@KateFriedman-NOAA KateFriedman-NOAA mentioned this pull request Jan 27, 2023
Closed
5 tasks
@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this pull request Jan 27, 2023
Merged
14 tasks
@BrianCurtis-NOAA
Copy link
Collaborator

Dogwood just opened up. Starting RT.

@jkbk2004
Copy link
Collaborator

Dogwood just opened up. Starting RT.

Cool!

@BrianCurtis-NOAA
Copy link
Collaborator

Since everything looks OK this morning, I'll start the upstream merge process.

@jkbk2004
Copy link
Collaborator

Since everything looks OK this morning, I'll start the upstream merge process.

@BrianCurtis-NOAA Thanks!

@jkbk2004
Copy link
Collaborator

@BrianCurtis-NOAA the fv3atm pr was merged.

@jkbk2004 jkbk2004 merged commit c22aaad into ufs-community:develop Jan 30, 2023
@dustinswales dustinswales mentioned this pull request Feb 9, 2023
Merged
@yangfanglin yangfanglin mentioned this pull request Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SadeghTabas-NOAA SadeghTabas-NOAA SadeghTabas-NOAA approved these changes

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

@BrianCurtis-NOAA BrianCurtis-NOAA BrianCurtis-NOAA approved these changes

@zach1221 zach1221 zach1221 approved these changes

Assignees
No one assigned
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ChunxiZhang-NOAA @jkbk2004 @BrianCurtis-NOAA @zach1221 @SadeghTabas-NOAA @DusanJovic-NOAA @epic-cicd-jenkins