-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Add ccpp-scm reference #842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clouden90 Rather than just referring to sections in the User's Guide, I think it is best to provide a direct link to section 5.2 and 2.5. I'm also concerned about the details of section 5.2 (Running the SRW App's Grid Configuration section) and 2.5 (There is no section 2.5 in the user's guide, Chapter 2 only goes to 2.2 Quick Start Guide's Building and Running the UFS SRW Application). Are you sure that these are the sections that you want to point to here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the Components.rst
section has been updated to note that the sections are in the CCPP-SCM User's Guide, rather than the SRW App's User Guide, I will go ahead and approve these changes.
This is an emergency PR to add the CCPP-SCM documentation into the |
Thanks for the review, @chan-hoo! I will now move forward with merging this work. |
DESCRIPTION OF CHANGES:
The reference of CCPP-SCM was missing in #822. Here we add it back.
DEPENDENCIES:
#822
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR: