-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Added environment variable LDFLAGS on macOS as requested by the corresponding module file #729
Merged
MichaelLueken
merged 4 commits into
ufs-community:develop
from
ywangwof:feature/devbuildMacOS
May 1, 2023
Merged
[develop] Added environment variable LDFLAGS on macOS as requested by the corresponding module file #729
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3677147
Added environment variable LDFLAGS on macOS as requested by the corre…
ywangwof eb77115
Changed to append to LDFLAGS but not replace
ywangwof 82f1276
Modified changes based on comments
ywangwof a1c2543
Modify modulefiles/build_macos_gnu.lua based on comments from Natelie
ywangwof File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting changes to the modulefile build_macos_gnu.lua instead of adding conditionals to devbuild.sh
Lines 59-65 of build_macos_gnu.lua to be changed to a single line adding a flag to the existing ones (note "+=" instead of "=", and spaces before "L" and after "lib")
export LDFLAGS+=" -L$MPI_ROOT/lib "
Another change that is needed for build_macos_gnu.lua in lines 49-50:
instead of "macos.<compiler>".
The ufs-weather-model expects "macosx.<compiler>" as a platform name, and it has
ufs-weather-model/cmake/configure_macosx.gnu.cmake
andconfigure_macosx.intel.cmake
platform-dependent configuration files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export LDFLAGS+=" -L$MPI_ROOT/lib "
does not work in a Lua module file. Note that it is a shell command.build_macos_gnu.lua
, the file name should also be changed tobuild_macosx_gnu.lua
to be consistent. And all other scripts that mentionedbuild_macos_gnu
should also be changed.It will be involved too many modifications and is error prone. I prefer to leaving it to the next major version update? My current modification is not perfect, but it requests the minimal changes that make the script
devbuild.sh
work on the macOS platform.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ywangwof -
Thank you for your responses!
append_path (”LDFLAGS”, “ -L$MPI_ROOT/lib ", “ ”)
it will not work either, because the $MPI_ROOT could only be expanded after the modulefile is loaded; it is not yet available inside the modulefile.
Your solution to modify devbuild.sh is then a good option. My only suggestion is to use a conditional based on a $PLATFORM variable, because we may have other compilers Intel, Clang. The line 452 in devbuild.sh then would be:
if [[ "${PLATFORM}" == "macos" ]]; then
Agree. If a platform+compiler naming for the SRW differs from that for the UFS-WM, but still works for the SRW system, it's OK to leave it unchanged.
Modulefiles build_macos_gnu.lua may still need a correction to the syntax for the export LDFLAGS string, suggesting: