Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Add upgrade option to check_for_preexist_dir. #645

Merged

Conversation

danielabdi-noaa
Copy link
Collaborator

@danielabdi-noaa danielabdi-noaa commented Mar 7, 2023

DESCRIPTION OF CHANGES:

Addresses issue #655. Add upgrade option besides delete, rename, quit when checking for existing experiment directory (or another folder). For EXPTDIR the behavior is different from other directories. The "upgrade" option behaves like rsync for EXPTDIR. The workflow generation is handled by python code in SRW app, therefore check_for_preexist_dir.py handles that. For other directories, the shell version of the script is used, and upgrade means reuse existing directory. Apparently this option is sometimes useful for RRFS_dev1 workflow runs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

DOCUMENTATION:

ISSUE:

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

ush/config_defaults.yaml Outdated Show resolved Hide resolved
@danielabdi-noaa danielabdi-noaa linked an issue Mar 8, 2023 that may be closed by this pull request
@danielabdi-noaa danielabdi-noaa self-assigned this Mar 14, 2023
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielabdi-noaa These changes look good to me! I was able to clone this work on Jet, submit the fundamental WE2E tests, then reran them using the new reuse method. The new method worked as described in the PR. All tests for both runs successfully passed. Approving these changes now.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Apr 3, 2023
@MichaelLueken
Copy link
Collaborator

@danielabdi-noaa The Jenkins tests on Cheyenne Intel have finally passed successfully. Moving forward with merging this work now.

@MichaelLueken MichaelLueken merged commit 36084eb into ufs-community:develop Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Upgrade EXPTDIR directory option.
3 participants