Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Rename variables that store task names #598

Merged

Conversation

gsketefian
Copy link
Collaborator

@gsketefian gsketefian commented Feb 8, 2023

DESCRIPTION OF CHANGES:

To be consistent with the naming convention used for variables that specify per-task properties (e.g. PPN_RUN_FCST, WTIME_RUN_FCST, MAXTRIES_RUN_FCST), rename variables that store the task names (e.g. RUN_FCST_TN) so that the "TN" part is at the beginning, e.g. TN_RUN_FCST.

This PR is part of a series to enhance the verification capabilities of the SRW App.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

The following fundamental tests were run on Hera using the Intel compiler. All were successful.

From fundamental.hera.gnu.com and/or fundamental.hera.intel.nco:

  • MET_ensemble_verification
  • MET_verification
  • MET_verification_only_vx
  • community_ensemble_2mems
  • community_ensemble_2mems_stoch
  • grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp
  • grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional_plot
  • grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
  • grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
  • grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
  • grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2
  • grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR
  • grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1beta
  • pregen_grid_orog_sfc_climo

From previous versions of fundamental.hera.gnu.com and/or fundamental.hera.intel.nco:

  • grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
  • grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta
  • nco_grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR

DOCUMENTATION:

The documentation has been updated to reflect the changes in the PR.

ISSUE:

Resolves issue #599.

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
    N/A
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published
    N/A

@gsketefian gsketefian marked this pull request as ready for review February 8, 2023 22:59
@MichaelLueken MichaelLueken linked an issue Feb 9, 2023 that may be closed by this pull request
@MichaelLueken MichaelLueken changed the title Rename variables that store task names [develop] Rename variables that store task names Feb 9, 2023
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsketefian These changes look good to me!

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Feb 9, 2023
@MichaelLueken
Copy link
Collaborator

@gsketefian The issues from Jenkins are due to the fact that I had to manually abort the Hera tests (even though the Hera tests are shut off in the Jenkinsfile). All tests have successfully passed the Jenkins tests, so I will now move forward with merging this PR.

@MichaelLueken MichaelLueken merged commit b505e50 into ufs-community:develop Feb 9, 2023
@gsketefian gsketefian deleted the feature/rename_tn_vars branch February 14, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename variables that store workflow task names
3 participants