Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/public-v2.1.0]: Update the docs, add an errata file #557

Conversation

natalie-perlin
Copy link
Collaborator

DESCRIPTION OF CHANGES:

Updates to the Users Guide, Session on running the SRW on MacOS and generic Linux using standalone wrapper scripts. An errata file is added to the main directory.

Files changed:
./docs/UsersGuide/source/RunSRW.rst
./ERRATA.md (new file)

Type of change

  • Documentation changes

TESTS CONDUCTED:

  • macos.gnu
  • hera.gnu (tested functionality)
  • cheyenne.gnu (tested functionality)
  • NOAA Cloud, AWS, tested functionality

DEPENDENCIES:

DOCUMENTATION:

This PR updated the documentation for the release/public-v2.1.0 branch.

ISSUE:

This PR resolves the issue #473
The issue has also been mentioned and discussed in the PR #507 and #508.

CHECKLIST

  • My changes update the documentation.

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • correction of the documentation for the release/public-v2.1.0
  • documentation
  • release

CONTRIBUTORS (optional):

Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natalie-perlin Thanks for adding the necessary commands to make the wrapper scripts work to the documentation and the errata file! The only request I have is to replace the <release-tag> entry with ufs-srw-v2.1.0, the name of the release tag. Otherwise, these changes look good to me!

ERRATA.md Outdated Show resolved Hide resolved
Update the tag name for the release
@MichaelLueken MichaelLueken linked an issue Jan 24, 2023 that may be closed by this pull request
@MichaelLueken MichaelLueken added documentation Improvements or additions to documentation release This PR/issue is related to a release branch labels Jan 24, 2023
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natalie-perlin Thanks! Approving this PR now.

@MichaelLueken MichaelLueken merged commit e9fb2b6 into ufs-community:release/public-v2.1.0 Jan 24, 2023
@natalie-perlin natalie-perlin deleted the release/public-v2.1.0_docs branch October 13, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation release This PR/issue is related to a release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running SRW using wrapper launch scripts is not working
2 participants