Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test experiment MET_ensemble_verification_only_vx_time_lag can not be created due to invalid variable "NET" #851

Closed
mkavulich opened this issue Jul 6, 2023 · 0 comments · Fixed by #864 or #868
Assignees
Labels
bug Something isn't working

Comments

@mkavulich
Copy link
Collaborator

mkavulich commented Jul 6, 2023

Expected behavior

All WE2E tests should succeed, including MET_ensemble_verification_only_vx_time_lag

Current behavior

Since #828, the workflow creation script now fails when attempting to run this experiment:

Calling workflow generation function for test MET_ensemble_verification_only_vx_time_lag


*********************************************************************
FATAL ERROR:
Experiment generation failed. See the error message(s) printed below.
For more detailed information, check the log file from the workflow
generation script: log.run_WE2E_tests
*********************************************************************

Traceback (most recent call last):
  File "/mnt/lfs4/BMC/gsd-fv3-dev/kavulich/workdir/test_develop/2023-07-01/ufs-srweather-app/tests/WE2E/./run_WE2E_tests.py", line 507, in <module>
    run_we2e_tests(homedir,args)
  File "/mnt/lfs4/BMC/gsd-fv3-dev/kavulich/workdir/test_develop/2023-07-01/ufs-srweather-app/tests/WE2E/./run_WE2E_tests.py", line 204, in run_we2e_tests
    expt_dir = generate_FV3LAM_wflow(ushdir,logfile=f"{ushdir}/log.generate_FV3LAM_wflow",
  File "/mnt/lfs4/BMC/gsd-fv3-dev/kavulich/workdir/test_develop/2023-07-01/ufs-srweather-app/tests/WE2E/../../ush/generate_FV3LAM_wflow.py", line 71, in generate_FV3LAM_wflow
    expt_config = setup(ushdir,debug=debug)
  File "/mnt/lfs4/BMC/gsd-fv3-dev/kavulich/workdir/test_develop/2023-07-01/ufs-srweather-app/tests/WE2E/../../ush/setup.py", line 379, in setup
    expt_config = load_config_for_setup(USHdir, default_config_fp, user_config_fp)
  File "/mnt/lfs4/BMC/gsd-fv3-dev/kavulich/workdir/test_develop/2023-07-01/ufs-srweather-app/tests/WE2E/../../ush/setup.py", line 105, in load_config_for_setup
    raise Exception(errmsg)
Exception: Invalid key(s) specified in /mnt/lfs4/BMC/gsd-fv3-dev/kavulich/workdir/test_develop/2023-07-01/ufs-srweather-app/ush/config.yaml:
NET = RRFSE_CONUS

Check /mnt/lfs4/BMC/gsd-fv3-dev/kavulich/workdir/test_develop/2023-07-01/ufs-srweather-app/ush/config_defaults.yaml for allowed user-specified variables

Machines affected

All

Steps To Reproduce

  1. Attempt to run WE2E test MET_ensemble_verification_only_vx_time_lag
  2. Observe failure
@mkavulich mkavulich added the bug Something isn't working label Jul 6, 2023
@mkavulich mkavulich self-assigned this Jul 6, 2023
gsketefian added a commit to gsketefian/ufs-srweather-app that referenced this issue Jul 20, 2023
…bles that got the _default prefix appended by PR #) where necessary to address bug in Issue ufs-community#851 (the WE2E test "MET_ensemble_verification_only_vx_time_lag" is failing).
@MichaelLueken MichaelLueken linked a pull request Jul 21, 2023 that will close this issue
37 tasks
MichaelLueken pushed a commit that referenced this issue Jul 25, 2023
The renaming of the configuration variable NET to NET_default by PR #828 broke the WE2E test MET_ensemble_verification_only_vx_time_lag (see Issue #851). This PR fixes the bug and adds that WE2E test to the list of coverage tests on Hera (currently that test is only in the comprehensive tests list).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant