Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rst documentation for using template variables #230

Closed
jwolff-ncar opened this issue Mar 24, 2022 · 8 comments
Closed

Update rst documentation for using template variables #230

jwolff-ncar opened this issue Mar 24, 2022 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@jwolff-ncar
Copy link
Collaborator

Description

This is moved from regional_workflow (issue #651). Update rst documentation for variables introduced in PR ufs-community/regional_workflow#650 for using template variables. Documentation already exists in the WE2E test configuration file config.template_vars.sh (in the directory regional_workflow/tests/WE2E/test_configs/wflow_features).

Solution

Update the necessary rst file.

@jwolff-ncar jwolff-ncar added the enhancement New feature or request label Mar 24, 2022
@jwolff-ncar jwolff-ncar added this to the v2 release milestone Mar 24, 2022
@jwolff-ncar jwolff-ncar added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Mar 24, 2022
@gspetro-NOAA
Copy link
Collaborator

@JeffBeck-NOAA Was this taken care of with the edits for the Workflow Configuration chapter (with config_defaults.sh info) for the v2 release? Can we close it?

@JeffBeck-NOAA
Copy link
Collaborator

@gspetro-NOAA, I believe this issue was going to be resolved with this PR, but it was never merged. @gsketefian, anything to add here?

@gsketefian
Copy link
Collaborator

I closed that PR since things changed so much that it got out of date. I am not up-to-date on how template variables can be used now in the config file.

@JeffBeck-NOAA
Copy link
Collaborator

Thanks, @gsketefian. @gspetro-NOAA, I guess we should leave this issue open and tag the code developer who introduced the new template changes.

@gsketefian
Copy link
Collaborator

Yeah, probably @danielabdi-noaa is the best person after the yaml configuration PR is in.

@danielabdi-noaa
Copy link
Collaborator

@gsketefian I learned about the templates you described just now after reading the description in your PR so not sure if I am the best person for this task. The yaml conversion maintains the template functionality because templates are still either single quoted or not quoted (same thing), thus are not interpreted until they are actually eval'ed. Other than that, I think the your PR describes it well.

@JeffBeck-NOAA
Copy link
Collaborator

Thanks, @danielabdi-noaa! @gsketefian, since it sounds like your documentation is fine as is (aside from adding the explanation that Daniel provided), are you willing to reopen it?

@MichaelLueken
Copy link
Collaborator

Closed by #528.

SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-srweather-app that referenced this issue Sep 15, 2023
1) run soil adjustment parallel
2) run model with 36s time step.
3) bug fix to turn off radiance in direct reflectivity GSI hybrid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

6 participants