-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rst documentation for using template variables #230
Comments
@JeffBeck-NOAA Was this taken care of with the edits for the Workflow Configuration chapter (with config_defaults.sh info) for the v2 release? Can we close it? |
@gspetro-NOAA, I believe this issue was going to be resolved with this PR, but it was never merged. @gsketefian, anything to add here? |
I closed that PR since things changed so much that it got out of date. I am not up-to-date on how template variables can be used now in the config file. |
Thanks, @gsketefian. @gspetro-NOAA, I guess we should leave this issue open and tag the code developer who introduced the new template changes. |
Yeah, probably @danielabdi-noaa is the best person after the yaml configuration PR is in. |
@gsketefian I learned about the templates you described just now after reading the description in your PR so not sure if I am the best person for this task. The yaml conversion maintains the template functionality because templates are still either single quoted or not quoted (same thing), thus are not interpreted until they are actually eval'ed. Other than that, I think the your PR describes it well. |
Thanks, @danielabdi-noaa! @gsketefian, since it sounds like your documentation is fine as is (aside from adding the explanation that Daniel provided), are you willing to reopen it? |
Closed by #528. |
1) run soil adjustment parallel 2) run model with 36s time step. 3) bug fix to turn off radiance in direct reflectivity GSI hybrid.
Description
This is moved from regional_workflow (issue #651). Update rst documentation for variables introduced in PR ufs-community/regional_workflow#650 for using template variables. Documentation already exists in the WE2E test configuration file config.template_vars.sh (in the directory regional_workflow/tests/WE2E/test_configs/wflow_features).
Solution
Update the necessary rst file.
The text was updated successfully, but these errors were encountered: