-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change output file name of run_post to meet NCO standards #758
Changes from 1 commit
a71495a
dcbc8e4
4398d5a
02341cb
d8dcade
047293a
ee936fa
06ff778
c880667
2dbf122
ec62a8c
1b9fd98
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -514,7 +514,6 @@ if [ ${WRITE_DOPOST} = "TRUE" ]; then | |
yyyymmdd=${cdate:0:8} | ||
hh=${cdate:8:2} | ||
cyc=$hh | ||
tmmark="tm00" | ||
fmn="00" | ||
|
||
if [ "${RUN_ENVIR}" = "nco" ]; then | ||
|
@@ -539,15 +538,15 @@ if [ ${WRITE_DOPOST} = "TRUE" ]; then | |
post_mn=${post_time:10:2} | ||
post_mn_or_null="" | ||
post_fn_suffix="GrbF${fhr_d}" | ||
post_renamed_fn_suffix="f${fhr}${post_mn_or_null}.${tmmark}.grib2" | ||
post_renamed_fn_suffix="f${fhr}${post_mn_or_null}.${FN_OUT_DOMAIN}.grib2" | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you have an example of what a full post file name looks like after this change? Does it still have the "prslev" and "natlev" names in the files? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It should be |
||
basetime=$( $DATE_UTIL --date "$yyyymmdd $hh" +%y%j%H%M ) | ||
symlink_suffix="_${basetime}f${fhr}${post_mn}" | ||
fids=( "prslev" "natlev" ) | ||
for fid in "${fids[@]}"; do | ||
FID=$(echo_uppercase $fid) | ||
post_orig_fn="${FID}.${post_fn_suffix}" | ||
post_renamed_fn="${NET}.t${cyc}z.${fid}${post_renamed_fn_suffix}" | ||
post_renamed_fn="${NET}.t${cyc}z.${fid}.${post_renamed_fn_suffix}" | ||
mv_vrfy ${run_dir}/${post_orig_fn} ${post_renamed_fn} | ||
ln_vrfy -fs ${post_renamed_fn} ${FID}${symlink_suffix} | ||
done | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -172,17 +172,6 @@ cyc=$hh | |
# | ||
#----------------------------------------------------------------------- | ||
# | ||
# The tmmark is a reference value used in real-time, DA-enabled NCEP models. | ||
# It represents the delay between the onset of the DA cycle and the free | ||
# forecast. With no DA in the SRW App at the moment, it is hard-wired to | ||
# tm00 for now. | ||
# | ||
#----------------------------------------------------------------------- | ||
# | ||
tmmark="tm00" | ||
# | ||
#----------------------------------------------------------------------- | ||
# | ||
# Create the namelist file (itag) containing arguments to pass to the post- | ||
# processor's executable. | ||
# | ||
|
@@ -300,7 +289,7 @@ if [ "${post_mn}" != "00" ]; then | |
fi | ||
|
||
post_fn_suffix="GrbF${post_fhr}${dot_post_mn_or_null}" | ||
post_renamed_fn_suffix="f${fhr}${post_mn_or_null}.${tmmark}.grib2" | ||
post_renamed_fn_suffix="f${fhr}${post_mn_or_null}.${FN_OUT_DOMAIN}.grib2" | ||
# | ||
# For convenience, change location to postprd_dir (where the final output | ||
# from UPP will be located). Then loop through the two files that UPP | ||
|
@@ -314,7 +303,7 @@ fids=( "prslev" "natlev" ) | |
for fid in "${fids[@]}"; do | ||
FID=$(echo_uppercase $fid) | ||
post_orig_fn="${FID}.${post_fn_suffix}" | ||
post_renamed_fn="${NET}.t${cyc}z.${fid}${post_renamed_fn_suffix}" | ||
post_renamed_fn="${NET}.t${cyc}z.${fid}.${post_renamed_fn_suffix}" | ||
mv_vrfy ${tmp_dir}/${post_orig_fn} ${post_renamed_fn} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question as above, but this time post_orig_fn vs post_renamed_fn. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Explained above. |
||
create_symlink_to_file target="${post_renamed_fn}" \ | ||
symlink="${FID}${symlink_suffix}" \ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chan-hoo, is there a reason to have "post_fn_suffix" and "post_renamed_fn_suffix"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffBeck-NOAA, when I added this part for the inline post option, I copied the corresponding part in 'exregional_run_post.sh' as you pointed below. I am not the original developer of the script, but I can interpret them as follows: (1) The output file name of UPP and inline post is 'post_orig_fn' including 'post_fn_suffix'. (2) The output file name required by NCO is 'post_renamed_fn' including 'post_renamed_fn_suffix'. (3) File (1) is renamed to File (2), and the original file name (1) is soft-linked to file (2).