Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline post option to the SRW App #538

Merged
merged 10 commits into from
Jul 7, 2021
Merged

Add inline post option to the SRW App #538

merged 10 commits into from
Jul 7, 2021

Conversation

chan-hoo
Copy link
Collaborator

@chan-hoo chan-hoo commented Jul 6, 2021

DESCRIPTION OF CHANGES:

  • Add the parameter 'write_dopost' for inline post to model_configure.
  • Turn off the 'run_post' task when 'write_dopost'='.true.'
  • Add post-processing for inline post to the 'run_fcst' script.
  • Modify the dependency for verification in the workflow template.
  • Add a new WE2E test for inline post.

TESTS CONDUCTED:

  • GST + verification on Hera and WCOSS Dell
  • New WE2E test for inline post

DEPENDENCIES:

ISSUE:

Copy link
Collaborator

@JeffBeck-NOAA JeffBeck-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like WRITE_DOPOST automatically sets RUN_TASK_RUN_POST=FALSE anywhere. Can you make this change in setup.sh?

@chan-hoo
Copy link
Collaborator Author

chan-hoo commented Jul 6, 2021

@JeffBeck-NOAA, You can find it on Line 2139 in setup.sh

@JeffBeck-NOAA
Copy link
Collaborator

@JeffBeck-NOAA, You can find it on Line 2139 in setup.sh

Thanks! Just missed it.

@JeffBeck-NOAA
Copy link
Collaborator

@chan-hoo, can you add a header to the WE2E test you've included in this PR? You can check out this PR to see how we're handling that now. Thanks!

@chan-hoo chan-hoo merged commit 47d5b4f into ufs-community:develop Jul 7, 2021
@chan-hoo chan-hoo deleted the feature/in_post branch July 7, 2021 17:56
@gsketefian
Copy link
Collaborator

@chan-hoo I was just merging this into one of my feature branches, and I started wondering if setting WRITE_DOPOST="TRUE" works with SUB_HOURLY_POST="TRUE"? If not, we should at least add a check, e.g. quit out of the experiment generation script if both of these are TRUE, and make an issue to fix this later on. Thanks.

# are stored (postprd_dir)
if [ ${WRITE_DOPOST} = "TRUE" ]; then
if [ "${RUN_ENVIR}" = "nco" ]; then
COMOUT="${COMOUT_BASEDIR}/$RUN.$PDY/$cyc${SLASH_ENSMEM_SUBDIR}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cyc is being used here before being set (below) since I don't see it set in JREGIONAL_RUN_FCST or FV3LAM_wflow.xml. Maybe this was missed because the WE2E test is in community mode.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsketefian, I'll fix this in a new PR for the nco mode.

fmn="00"

for fhr in $(seq -f "%02g" 0 ${FCST_LEN_HRS}); do
echo $fhr
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove echo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix this in a new PR for the nco mode.

@chan-hoo
Copy link
Collaborator Author

chan-hoo commented Jul 8, 2021

@gsketefian, I'll add the check for SUB_HOURLY_POST, but I am not familiar with SUB_HOURLY_POST. Can you assign this 'SUB_HOURLY_POST' issue to others who know better than me?

SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/regional_workflow that referenced this pull request Sep 15, 2023
* fix/lam/RRFS_NA_3km point to RRFS_NA_3km_C3463_Lake_fracSV

* updates from WCOSS2 and Hera for running NA 3km grid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants