-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline post option to the SRW App #538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like WRITE_DOPOST automatically sets RUN_TASK_RUN_POST=FALSE anywhere. Can you make this change in setup.sh?
@JeffBeck-NOAA, You can find it on Line 2139 in setup.sh |
Thanks! Just missed it. |
@chan-hoo I was just merging this into one of my feature branches, and I started wondering if setting WRITE_DOPOST="TRUE" works with SUB_HOURLY_POST="TRUE"? If not, we should at least add a check, e.g. quit out of the experiment generation script if both of these are TRUE, and make an issue to fix this later on. Thanks. |
# are stored (postprd_dir) | ||
if [ ${WRITE_DOPOST} = "TRUE" ]; then | ||
if [ "${RUN_ENVIR}" = "nco" ]; then | ||
COMOUT="${COMOUT_BASEDIR}/$RUN.$PDY/$cyc${SLASH_ENSMEM_SUBDIR}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think cyc
is being used here before being set (below) since I don't see it set in JREGIONAL_RUN_FCST or FV3LAM_wflow.xml. Maybe this was missed because the WE2E test is in community mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsketefian, I'll fix this in a new PR for the nco mode.
fmn="00" | ||
|
||
for fhr in $(seq -f "%02g" 0 ${FCST_LEN_HRS}); do | ||
echo $fhr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove echo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix this in a new PR for the nco mode.
@gsketefian, I'll add the check for SUB_HOURLY_POST, but I am not familiar with SUB_HOURLY_POST. Can you assign this 'SUB_HOURLY_POST' issue to others who know better than me? |
* fix/lam/RRFS_NA_3km point to RRFS_NA_3km_C3463_Lake_fracSV * updates from WCOSS2 and Hera for running NA 3km grid.
DESCRIPTION OF CHANGES:
TESTS CONDUCTED:
DEPENDENCIES:
ISSUE: