Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update WE2E testing suite #484

Closed
jwolff-ncar opened this issue May 5, 2021 · 5 comments
Closed

Review and update WE2E testing suite #484

jwolff-ncar opened this issue May 5, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request high priority

Comments

@jwolff-ncar
Copy link
Contributor

  • Come up with a full plan for what tests need to be run, where, when, and by whom, in addition to adding new tests when necessary
  • Add proper checks for input/output files, output difference testing
@mkavulich
Copy link
Collaborator

I originally opened this as its own issue but it is better contained here.

Currently there is an infeasible number of tests contained in regional_workflow/tests/baseline_configs. Even attempting to run most of them not only uses thousands of core hours and takes many wallclock hours even in periods of low machine usage, it often results in errors due to limits on the number of jobs a user can submit at one time:

05/13/21 20:36:30 UTC :: FV3LAM_wflow.xml :: sbatch: error: AssocMaxSubmitJobLimit sbatch: error: Batch job submission failed: Job violates accounting/QOS policy (job submit limit, user's size and/or time limits)

Nearly the same set of capabilities should be testable with a small subset of all these tests, helping mitigate these issues.

@mkavulich
Copy link
Collaborator

#490 is also relevant here, though I'm not sure if that fix would be in the test parameters or the workflow/code

@llpcarson
Copy link
Contributor

Also update RTs for the ufs-weather-model, to avoid duplication and ensure coverage of model configuration tests.

@mkavulich
Copy link
Collaborator

#531 Adds descriptions of each test and separates them into categories, this is a good first step to narrowing down the required test set for PRs

@jwolff-ncar jwolff-ncar added this to the v2 release milestone Feb 3, 2022
@jwolff-ncar jwolff-ncar removed this from the v2 release milestone Mar 16, 2022
@mkavulich
Copy link
Collaborator

Superseded by ufs-community/ufs-srweather-app#277

shoyokota pushed a commit to shoyokota/regional_workflow that referenced this issue Feb 21, 2023
Co-authored-by: benjamin blake <benjamin.blake@dlogin03.dogwood.wcoss2.ncep.noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority
Projects
None yet
Development

No branches or pull requests

6 participants