Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JCB gdas/algorithms as submodules #179

Merged
merged 8 commits into from
Jan 17, 2025

Conversation

chan-hoo
Copy link
Collaborator

Description

  • Add the JCB-GDAS and JCB-ALGORITHMS repos as submodules.
  • Add a new task jcb_test temporarily because spack-stack conflicts with conda in the tasks. Once the spack-stack is updated with 1.7.0 or above, this task should be merged into the analysis task.
  • Some clean-up of the analysis task script

Anticipated changes to regression tests:

  • Is baseline change expected ?

Subcomponents involved:

  • apply_incr.fd (NOAA-PSL/land-apply_jedi_incr)
  • ufs_model.fd (ufs-community/ufs-weather-model)
  • UFS_UTILS.fd (ufs-community/UFS_UTILS)
  • none

Linked PR's and Issues:

Resolve Issue #178

Testing (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Hercules
  • CI
    • Completed
  • WE2E
    • Completed
  • PW-Clouds
    • AWS
    • AZURE
    • GCP

@chan-hoo chan-hoo requested a review from jkbk2004 January 16, 2025 17:20
@chan-hoo chan-hoo linked an issue Jan 16, 2025 that may be closed by this pull request
@jkbk2004
Copy link
Collaborator

@chan-hoo we don't need to target for the use on wcoss2.

@chan-hoo
Copy link
Collaborator Author

@jkbk2004, yes, I agree. It is a kind of typical format for the j-job scripts. It is dummy for land-DA though. Do you want me to remove the wcoss2 part from all j-job scripts?

@chan-hoo
Copy link
Collaborator Author

On Hera:

+ ctest
Test project /scratch2/NAGAPE/epic/Chan-hoo.Jeon/landda_jcb/land-DA_workflow/sorc/build
    Start 1: test_create_ens
1/4 Test #1: test_create_ens ..................   Passed    3.48 sec
    Start 2: test_letkfoi_snowda
2/4 Test #2: test_letkfoi_snowda ..............   Passed   24.68 sec
    Start 3: test_apply_jediincr
3/4 Test #3: test_apply_jediincr ..............   Passed    2.25 sec
    Start 4: test_ufs_datm_land
4/4 Test #4: test_ufs_datm_land ...............   Passed   36.72 sec

100% tests passed, 0 tests failed out of 4

Total Test time (real) =  67.15 sec

@chan-hoo chan-hoo merged commit 33eb407 into ufs-community:develop Jan 17, 2025
2 checks passed
@chan-hoo chan-hoo deleted the feature/jcb branch January 22, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to set up JCB package and add JCB repositories as submodules
2 participants