Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple convective cloud to radiation #9

Merged

Conversation

dustinswales
Copy link
Collaborator

@dustinswales dustinswales commented Sep 29, 2022

Opened on behalf of @Qingfu-Liu, replacing #8
This PR contains adds the convective cloud water (liquid water + ice water) in the calculations of Cloud Water Path and Ice Water Path for radiation cloud properties.
For RRTMG radiation, only one file changed: radiation_clouds.f (code changed by Ruiyu Sun)
For RRTMGP radiation, one file has changed and there is an upstream change needed in NOAA-EMC/fv3atm for a new interstitial variable.

This will change the baselines for any RT using the Thompson MP scheme
TestingAndEvaluation_PR9.pdf

Copy link
Collaborator

@RuiyuSun RuiyuSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change in radiation_clouds routine looks fine

@RuiyuSun
Copy link
Collaborator

Some of the results from the change in the radiation_clouds routine can be seen
here. https://docs.google.com/presentation/d/14OJnTJZkO4EI-I3UQXLeRd0_AIVUOK9S/edit#slide=id.p11

@ChunxiZhang-NOAA
Copy link

@dustinswales Could you add Ruiyu's results into the description of this PR?

@dustinswales
Copy link
Collaborator Author

@dustinswales Could you add Ruiyu's results into the description of this PR?

@RuiyuSun @ChunxiZhang-NOAA I don't think that link is working.

@Qingfu-Liu
Copy link
Collaborator

Qingfu-Liu commented Sep 29, 2022 via email

Copy link

@ChunxiZhang-NOAA ChunxiZhang-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dustinswales
Copy link
Collaborator Author

@mzhangw @ChunxiZhang-NOAA
I forgot that we needed a fix for NCAR issue #957, and agreed to put it into this PR. Can you both review this addition?
@Qingfu-Liu @yangfanglin

@ChunxiZhang-NOAA
Copy link

ChunxiZhang-NOAA commented Nov 1, 2022

In radiation_clouds.f, Ruiyu's new recommendation is to change line 3909 from clwt = 1.0e-10 * (plyr(i,k)*0.001) to clwt = 1.0e-6 * (plyr(i,k)*0.001). @dustinswales Could you modify it in this PR?

@grantfirl
Copy link
Collaborator

@dustinswales Please update this to the latest ufs-dev branch when you get a chance in order to start testing.

@grantfirl
Copy link
Collaborator

@dustinswales Since the CI changes were merged, this needs to be updated to ufs/dev again before testing.

@grantfirl grantfirl merged commit 84d89f9 into ufs-community:ufs/dev Nov 22, 2022
@dustinswales dustinswales deleted the add_cnvcldcnd_mp2rad_cplng branch March 15, 2023 17:42
dustinswales pushed a commit that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants