Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/RRFS.v1] Thompson-Eidhammer microphysics code formatting #179

Merged

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Feb 28, 2024

This is @AndersJensen-NOAA 's work. A new PR was created targeting the RRFS release branch, and this supercedes #147

This PR is the first of many that will modernized, modularize, and streamline Thompson-Eidhammer microphysics.

This PR includes:

  1. The addition of parameterized kind: REAL -> real(kind_phys)
  2. Consistent indentation
  3. Removal of GOTO statements
  4. Physical constants are now coming from the host.

@grantfirl
Copy link
Collaborator Author

@mkavulich @AndersJensen-NOAA This one is next up for the RRFS release branch. It is ready to review/test.

@grantfirl
Copy link
Collaborator Author

grantfirl commented Mar 5, 2024

Reviewers (@AndersJensen-NOAA @mkavulich @dustinswales @Qingfu-Liu @mzhangw):

You may have previously reviewed #147, which this PR replaces. Most of the changes are identical to that with the exception of the physical constants change work. You can look in commits 716abb6 and 8718420 for the changes.

Basically, it's changing physical constants that were in module_mp_thompson.F90 from parameters to variables, exposing them to the mp_thompson_init routine and setting them from constants passed in from the host there. Derived constants that had been set in the declaration section had to be moved to the top of the execution in thompson_init since they're no longer parameters.

I decided not to create another separate mp_thompson_common module for physical constants (e.g. like is done for MYNN PBL) because they were already being defined at the module level in module_mp_thompson.

Copy link
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. Thanks @AndersJensen-NOAA and @grantfirl!
One question though, will there be a PR into ufs/dev for these changes as well?

@grantfirl
Copy link
Collaborator Author

These changes look good to me. Thanks @AndersJensen-NOAA and @grantfirl! One question though, will there be a PR into ufs/dev for these changes as well?

Yes. At some point, either after RRFS is released or even before, we can submit these same changes to ufs/dev.

@grantfirl grantfirl merged commit 09d7f2f into ufs-community:production/RRFS.v1 Mar 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants