Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update directory names for global workflow #899

Merged

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Feb 16, 2024

DESCRIPTION OF CHANGES:

Update directory names in the ice blend, snow and global_cycle scripts to be consistent with the latest global_workflow convention.

TESTS CONDUCTED:

  • Run relevant consistency tests locally on all Tier 1 machines. For this issue, these include the global_cycle, ice_blend and snow2mdl tests. See below for results.

DEPENDENCIES:

NOAA-EMC/global-workflow#2184

DOCUMENTATION:

N/A

ISSUE:

Fixes #897.

CONTRIBUTORS:

@KateFriedman-NOAA

Copy link
Collaborator

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lots of FIX* variables cleaned out and replaced with fuller paths. Left a few comments with suggestions to consider before I approve.

ush/emcsfc_ice_blend.sh Outdated Show resolved Hide resolved
ush/emcsfc_snow.sh Outdated Show resolved Hide resolved
ush/global_cycle.sh Outdated Show resolved Hide resolved
ush/global_cycle.sh Outdated Show resolved Hide resolved
ush/global_cycle_driver.sh Outdated Show resolved Hide resolved
ush/global_cycle_driver.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks @GeorgeGayno-NOAA !

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review February 21, 2024 16:22
@GeorgeGayno-NOAA GeorgeGayno-NOAA changed the title Update FIX* directory names Update directory names for global workflow Feb 21, 2024
@GeorgeGayno-NOAA
Copy link
Collaborator Author

Using 7c8cb56, the global_cycle, ice_blend and snow2mdl consistency tests were run on Hera, Jet, Orion, Hercules and Dogwood. All tests passed as expected.

Because of the new 'fixed' file variables, the global_cycle input fixed directory had to be rearranged a bit. The 'case' directories were moved to a new orog sub-directory. And so previous snapshots of 'develop' would still work, links were made to point at the old location.

dlogin02@ /lfs/h2/emc/nems/noscrub/emc.nems/UFS_UTILS/reg_tests/global_cycle/fix\ $ ls -lr
total 4
dr-xr-sr-x 5 emc.nems nems 4096 Feb 21 20:04 orog
lrwxrwxrwx 1 emc.nems nems   11 Feb 21 20:04 C768 -> ./orog/C768
lrwxrwxrwx 1 emc.nems nems   10 Feb 21 20:04 C48 -> ./orog/C48
lrwxrwxrwx 1 emc.nems nems   11 Feb 21 20:04 C192 -> ./orog/C192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update directory variables for global workflow
2 participants