Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use EPIC stack on Orion and Hera #846

Merged

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Aug 29, 2023

DESCRIPTION OF CHANGES:

The build modules for Orion and Hera were updated to use the EPIC-maintained library stack.

TESTS CONDUCTED:

Tests were conducted using the branch at 815fc5b (Orion) and 4496d3a (Hera) . For more details, see #789.

  • Compile branch on Orion and Hera using Intel.
  • Compile branch on Hera using GNU.
  • Run unit tests locally on Orion (Intel) and Hera (Intel and GNU). All tests passed
  • Run relevant consistency tests locally on Orion and Hera.

Some consistency tests failed. But the differences with the baseline were not significant. For details, see #789 (comment)

Baseline files for all failed tests will need to be updated.

DEPENDENCIES:

Coordinate with global workflow group:
NOAA-EMC/global-workflow#1311

DOCUMENTATION:

N/A

ISSUE:

Fixes #789.

This ensures consistency with the chosen stack.

Fixes ufs-community#789.
@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review August 29, 2023 14:57
@GeorgeGayno-NOAA
Copy link
Collaborator Author

@WalterKolczynski-NOAA can you or someone in the global workflow group test with my branch?

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as draft August 29, 2023 15:25
@WalterKolczynski-NOAA
Copy link
Contributor

@GeorgeGayno-NOAA I'm on leave today. I'll try to take a look tomorrow unless @KateFriedman-NOAA has the time.

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review August 29, 2023 18:38
Copy link
Collaborator

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Don't have time to test within global-workflow at the moment but will test when we need to move to this new hash or later. FYI, once the GSI works with intel 2022 I'll be working to move us all to spack-stack. That's on hold for the moment, so it's good to move to this EPIC maintained hpc-stack for now. Thanks!

@GeorgeGayno-NOAA
Copy link
Collaborator Author

@sanatcumar This PR updated some of the library versions on Hera. When you merge these changes to your #830 branch, your results could change (very slightly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test new EPIC-maintained hpc-stack on Hera and Orion
3 participants