global_cycle - Link to CCPP version of sfcsub.F #636
Conversation
Add submodule for ccpp repo. Just tinkering right now. Fixes ufs-community#424
interface to sfcsub.F. Fixes ufs-community#424.
|
The reason for min_ice=15% is because that is the value used in the current and all previous uncoupled GFS. |
|
Moorthi, |
|
Yes, it is because the coupled model allows for different min_ice for lakes
and ocean as CICE uses smaller thresholds.
Moorthi
…On Wed, Mar 23, 2022 at 7:53 PM ShanSun-NOAA ***@***.***> wrote:
Moorthi,
Thanks for your explanation. My follow-up question would be why min_ice
needs to be an array in gcycle/sfcsub. I think I found the answer here:
if (lakefrac(ix) > 0.0_kind_phys) then
min_ice(ix) = min_lakeice
else
min_ice(ix) = min_seaice
endif
Thanks,
Shan
—
Reply to this email directly, view it on GitHub
<#636 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYWTBQYZW4MQ2453CW3VBOVFTANCNFSM5RIU2AAQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
|
|
Thanks, Moorthi! |
@shansun6 I am only concerned about non-fractional grids (uncoupled mode) with this PR. There is another issue for converting global_cycle for fractional grids - #549 |
|
My local tests indicate the CCPP version of sfcsub.F is working. In fact, it is correcting a problem with skin and ice temperature at points with the minimum ice value. GFS and land groups - do you want to run a short parallel to test further? |
|
@GeorgeGayno-NOAA George, this great news. Will your update also affect CHGRES ? Do you plan to run a few cases to see the impact on ICs ? Should the global_cycle now work with fractional grid and NOAH MP ? I'd assume one has to run a cycled experiment to test your updates. |
chgres_cube does not use sfcsub.F. It reads in the tiled versions of the surface fields in the 'fix' directory. So the ICs will not be affected. For GFS v17, the global_cycle and model should use the same tiled surface fields. This PR does not address fractional grids (coupled mode). There is another issue open for that - #549. |
| @@ -6,7 +6,7 @@ | |||
| set(lib_src | |||
| machine.f90 | |||
| num_parthds.f90 | |||
| sfcsub.F | |||
| ../../ccpp-physics/physics/sfcsub.F | |||
There was a problem hiding this comment.
@GeorgeGayno-NOAA When I tried your ccpp-physics branch, ufs_utils failed to compile because this file ../../ccpp-physics/physics/sfcsub.F does not exist. For global-workflow, this file can be linked to ../../../ufs_model.fd/FV3/ccpp/physics/physics/sfcsub.F; otherwise, you need to check out this file from CCPP github repo.
There was a problem hiding this comment.
Try 'git clone --recursive'.
Or 'git submodule init', then 'git submodule update'
There was a problem hiding this comment.
Thanks for reviewing. I can't add fractional grid support for global_cycle (#549) until this PR is merged.
* origin/develop: Update ccpp submodule (ufs-community#827) Change length of character variable "mosaic_name" in "make_solo_mosaic.c" (ufs-community#824) Update GDAS INIT utility for GFS COM reorganization (ufs-community#820) Add backup calculation for orography and mask generation (ufs-community#713) Improve repository build script (ufs-community#819) Use latest wgrib2 executable on Jet. (ufs-community#816) chgres_cube - Minor update for high-resolution grids . (ufs-community#814) Update PR template (ufs-community#813) global_cycle - Add soil moisture nudging for NoahMP option (ufs-community#809) Release v1.10.0 (ufs-community#807) Run sfc_climo_gen utility on Hera (ufs-community#791) Fix bug in chgres_cube subroutine search_many (ufs-community#808) sfc_climo_gen - Output fractions of each vegetation/soil type category (ufs-community#748) Replace w3nco library with w3emc (ufs-community#802) Fix Debug compilation (ufs-community#800) Update WCOSS2 build module to use new ESMF v8.4.1 library. (ufs-community#799) Update chgres_cube documentation for duplicate grib2 records (ufs-community#795) Use latest Cray modules on WCOSS2 (ufs-community#792) Remove checksum attribute from global_cycle restart files (ufs-community#794) Remove goto statements from chgres_cube (ufs-community#775) FVCOM_TOOLS - Remove dependency on module_nwp_base.f90 (ufs-community#790) Remove "gcovr" step from the 'developer' workflow (ufs-community#785) Update build module for Cheyenne (ufs-community#783) GDAS Init utility - consolidate the copy of coldstart files (ufs-community#773) Remove support for ODIN machine (ufs-community#782) Update GDAS INIT utility to optionally use fracoro data (ufs-community#741) Option to build only application specific utilities (e.g. GFS) (ufs-community#777) Use combined IP/IP2 library (ufs-community#695) Initial updates to global_cycle for Noah-MP land model (ufs-community#774) New resolution options for the cpld_gridgen utility (ufs-community#769) Use new EPIC-maintained hpc-stack on Jet (ufs-community#771) Update GDAS initialization scripts for the new ENKF directory (ufs-community#764) Reduce memory usage in chgres_cube (ufs-community#766) Detect duplicate vertical levels in chgres_cube. (ufs-community#767) Point to new input orography directory. (ufs-community#758) Release version 1.9 (ufs-community#754) HAFSv1 grid nesting updates (ufs-community#752) Remove compiler warnings from chgres_cube (ufs-community#747) chgres_cube: Split input_data module into to 3 separate modules (ufs-community#744) More work on CI, checking with different versions of ESMF (ufs-community#742) Add processing of soil color to sfc_climo_gen (ufs-community#721) more work on CI - added Linux_versions workflow (ufs-community#739) Add TEST_FILE_DIR option to CMake build, where test data files can be found instead of using FTP. (ufs-community#732) adding developer workflow (ufs-community#724) Update GDAS INIT utility for v16.3. (ufs-community#723) OROG_GSL - Remove negative bias in orographic asymmetery (OA) fields (ufs-community#718) Incorporate BNU soil type data (ufs-community#717) High-resolution MODIS and STATSGO veg/soil data. (ufs-community#703) Run WCOSS2 consistency tests under role account (ufs-community#711) Fix macOS CI workflow (ufs-community#715) Add utility codes to create BNU soil texture data (ufs-community#707) Update chgres_cube to output netcdf4 file. (ufs-community#704) Incorporate high-res global VIIRS vegetation data. (ufs-community#699) Run grid_gen consistency tests in parallel. (ufs-community#697) Fix error handling in "link_fixdirs.sh". Add -L to the copy command. (ufs-community#701) Update for new fixed data directory structure (ufs-community#688) Add WCOSS2 support for tests (ufs-community#693) Increase test data pull timeout (ufs-community#692) Option to install binaries to any directory. (ufs-community#685) Update global_cycle to use the latest CCPP version of sfcsub.F (ufs-community#671) Incorporate weight_gen program. (ufs-community#677) Add install of jpeg-turbo to macos workflows (ufs-community#684) Improve logic in regression test driver script (ufs-community#681) Release v1.8 (ufs-community#679) Update link_fixdirs.sh for new data directories (ufs-community#672) Update default ice climatology in ./ush/global_cycle.sh. (ufs-community#664) Remove all references to WCOSS 1 from UFS_UTILS (ufs-community#667) Update workflows to use latest macOS and ubuntu (ufs-community#675) Update GDAS Initialization utility for recent HPSS tarball name change (ufs-community#666) Port UFS_UTILS to WCOSS2 (ufs-community#642) Fix chgres_cube to process GEFS GRIB2 data (ufs-community#658) Update global_cycle_driver.sh for GFS OPS directory convention (ufs-community#655) Update documentation for SRW App (ufs-community#656) New coupled model utility (ufs-community#647) Update support for S4 and enable regression testing (ufs-community#654) global_cycle - Link to CCPP version of sfcsub.F (ufs-community#636) Add processing of new global AFWA snow data to emcsfc_snow2mdl. (ufs-community#648) Update build module on Cheyenne (ufs-community#646) Move to Intel 2022 on Jet, Hera and Orion (ufs-community#650) Host doxygen documentation for multiple releases (ufs-community#644) Download unit test data as part of the CMake build (ufs-community#630) chgres_cube - Complete removal of wgrib2 library (ufs-community#641) Eliminate circular dependency in chgres_cube Update workflow files to pull netcdf-c library from GitHub chgres_cube - Remove the wgrib2 library from the GRIB2 data read routines. Undefined symbols on macOS with Intel compiler (ufs-community#628) Update FVCOM code to handle sub-domain restart files using multiple cores. (ufs-community#624) chgres_cube - Run routine 'convert_omega' on all tasks. (ufs-community#627) Use ESMF 8.2.0 library Automate update of consistency test baseline data. (ufs-community#603) Update workflow files to use newer versions of ESMF and NCEPLIBS. (ufs-community#617) Update build modules to be lua compliant (ufs-community#614) Allow FVCOM tools to Update Ice Surface Roughness Length (ufs-community#604) Update the requested memory in the Orion chgres_cube consistency test script (ufs-community#611) Use copy of grib_util under Jet role account. (ufs-community#608) Run consistency tests on Orion using role account (ufs-community#606) Run consistency tests on Hera using role account (ufs-community#605) Run consistency tests on Jet using role account. (ufs-community#607) Update more documentation after move to ufs-community (ufs-community#597) fvcom_tools - Add option to process 'cold' or 'warm' restart files (ufs-community#595) Update documentation after move to ufs-community (ufs-community#594) chgres_cube - Eliminate segmentation fault in input_data.F90 (ufs-community#585) Update to language of unit test README to match that in unit test. chgres_cube - Simplify surface processing using field bundles (ufs-community#572) Add compiler flags for GNU Fortran v10 or newer compilers. (ufs-community#583) Move verbose output from example unit test to be commented to streamline test output. Updates to test README to add instructions for use of example unit test. Add Findwgrib2.cmake (ufs-community#578) Added unit test to be used as an instructional example for new users.
DESCRIPTION OF CHANGES:
Eliminate local copy of sfcsub.F by linking to the CCPP version. Update driver to pass additional fields - a minimum ice array, a landmask, and a water mask.
TESTS CONDUCTED:
So far, the consistency tests were run.
DEPENDENCIES:
None
DOCUMENTATION:
N/A
ISSUE:
Fixes #424