Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the GDAS_INIT utility to Jet #563

Merged

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

Port the utility to support the global_workflow group.

Fixes #544

@GeorgeGayno-NOAA
Copy link
Collaborator Author

@KateFriedman-NOAA Please run your own tests on Jet.

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review August 12, 2021 13:10
@KateFriedman-NOAA
Copy link
Collaborator

@KateFriedman-NOAA Please run your own tests on Jet.

Running tests now, will report back, thanks!

@KateFriedman-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA I have run two tests on Jet:

clone with your PR branch: /lfs4/HFIP/hfv3gfs/Kate.Friedman/git/fork_feature-init_path/sorc/ufs_utils.fd

  1. ran global-workflow free-forecast mode...the gfsinit job ran successfully and produced cold start ICs

/lfs4/HFIP/hfv3gfs/Kate.Friedman/ptmp/comrot/pruu563/logs/2021073100/gfsinit.log
/lfs4/HFIP/hfv3gfs/Kate.Friedman/ptmp/comrot/pruu563/logs/2021073106/gfsinit.log

  1. ran gdas_init offline successfully

/lfs4/HFIP/hfv3gfs/Kate.Friedman/git/fork_feature-init_path/sorc/ufs_utils.fd/util/gdas_init/config
/lfs4/HFIP/hfv3gfs/Kate.Friedman/git/fork_feature-init_path/sorc/ufs_utils.fd/util/gdas_init/log.data.v16retro
/lfs4/HFIP/hfv3gfs/Kate.Friedman/git/fork_feature-init_path/sorc/ufs_utils.fd/util/gdas_init/log.enkf
/lfs4/HFIP/hfv3gfs/Kate.Friedman/git/fork_feature-init_path/sorc/ufs_utils.fd/util/gdas_init/log.gdas
/lfs4/HFIP/hfv3gfs/Kate.Friedman/ptmp/gdas.init/output

Looks good to me, thanks!

@GeorgeGayno-NOAA
Copy link
Collaborator Author

@GeorgeGayno-NOAA I have run two tests on Jet:

clone with your PR branch: /lfs4/HFIP/hfv3gfs/Kate.Friedman/git/fork_feature-init_path/sorc/ufs_utils.fd

  1. ran global-workflow free-forecast mode...the gfsinit job ran successfully and produced cold start ICs

/lfs4/HFIP/hfv3gfs/Kate.Friedman/ptmp/comrot/pruu563/logs/2021073100/gfsinit.log
/lfs4/HFIP/hfv3gfs/Kate.Friedman/ptmp/comrot/pruu563/logs/2021073106/gfsinit.log

  1. ran gdas_init offline successfully

/lfs4/HFIP/hfv3gfs/Kate.Friedman/git/fork_feature-init_path/sorc/ufs_utils.fd/util/gdas_init/config
/lfs4/HFIP/hfv3gfs/Kate.Friedman/git/fork_feature-init_path/sorc/ufs_utils.fd/util/gdas_init/log.data.v16retro
/lfs4/HFIP/hfv3gfs/Kate.Friedman/git/fork_feature-init_path/sorc/ufs_utils.fd/util/gdas_init/log.enkf
/lfs4/HFIP/hfv3gfs/Kate.Friedman/git/fork_feature-init_path/sorc/ufs_utils.fd/util/gdas_init/log.gdas
/lfs4/HFIP/hfv3gfs/Kate.Friedman/ptmp/gdas.init/output

Looks good to me, thanks!

Great. Add your review to this PR and I will merge.

Copy link
Collaborator

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and were tested successfully on Jet.

@GeorgeGayno-NOAA
Copy link
Collaborator Author

Changes look good and were tested successfully on Jet.

Thanks @KateFriedman-NOAA. I will create a release for you. Maybe not today. Can you wait until next Monday?

@KateFriedman-NOAA
Copy link
Collaborator

I will create a release for you. Maybe not today. Can you wait until next Monday?

Monday is fine! Thanks @GeorgeGayno-NOAA !

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit a4f07f3 into ufs-community:develop Aug 13, 2021
@GeorgeGayno-NOAA GeorgeGayno-NOAA deleted the feature/gdas_init_jet branch August 13, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port GDAS INIT scripts to Jet
2 participants