Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up "orog" program (mtnlm7_oclsm.f) to eliminate segmentation faults on MACOS #545

Merged
merged 18 commits into from
Jul 23, 2021
Merged

Clean up "orog" program (mtnlm7_oclsm.f) to eliminate segmentation faults on MACOS #545

merged 18 commits into from
Jul 23, 2021

Commits on Jul 19, 2021

  1. Clean up in/out argument declarations

    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    816adc8 View commit details
    Browse the repository at this point in the history

  2. Organize variables by type

    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    c6f8407 View commit details
    Browse the repository at this point in the history

  3. Rearrange/consolidate integer declarations

    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    0c1cb9c View commit details
    Browse the repository at this point in the history

  4. Organize, consolidate, and standardize variable declarations

    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    75a30ed View commit details
    Browse the repository at this point in the history

  5. Change all statically defined arrays to dynamically allocated arrays.… 

    … I have no idea why this fixes the segfaults, but it does
    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    29fe679 View commit details
    Browse the repository at this point in the history

  6. Start adding/organizing "deallocate" statements

    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    0e6007c View commit details
    Browse the repository at this point in the history

  7. More rearranging of allocations and deallocations; this minor shuffle… 

    … results in a 30% reduction in memory footprint!
    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    e3a25df View commit details
    Browse the repository at this point in the history

  8. More rearrangement of allocate/deallocate statements, move element-wi… 

    …se assignment of one array to another out of a loop for faster execution
    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    58a1bd2 View commit details
    Browse the repository at this point in the history

  9. More shuffling of allocations/deallocations

    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    3220f6b View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary loop over ZSLM

    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    f7a7987 View commit details
    Browse the repository at this point in the history

  11. More variable allocation/deallocation shuffling, remove WZ4 variable … 

    …which is unused
    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    6249ab2 View commit details
    Browse the repository at this point in the history

  12. Finish allocation/deallocation shuffling, fix error introduced previo… 

    …usly where ZAVG should have been initialized from glob.
    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    c895b04 View commit details
    Browse the repository at this point in the history

  13. Some comment fixes

    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    9a40e31 View commit details
    Browse the repository at this point in the history

  14. Organize variables by dimensionality

    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    bbc6a03 View commit details
    Browse the repository at this point in the history

  15. Remove unused variables from modified subroutines

    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    1a3df6d View commit details
    Browse the repository at this point in the history

  16. Explicitly deallocate all allocated variables

    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    8a1d064 View commit details
    Browse the repository at this point in the history

  17. Accidentally deallocated twice

    @mkavulich
    mkavulich committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    daf0744 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Merge branch 'develop' into fix_orog_segfault

    @mkavulich
    mkavulich committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    8c98729 View commit details
    Browse the repository at this point in the history