more doxygen for sorc/nst_ft_chg.fd

[edwardhartnett]

Part of #191

@GeorgeGayno-NOAA another PR with doxygen.

[yangfanglin]

Approved. These are changes made for documentation

[GeorgeGayno-NOAA]

Got two warnings when building. This code no longer works. Should we bother to update it or just remove it? See #90.

[yangfanglin]

Ed, please add Xu.li@noaa.gov as a reviewer, and ask him if this program can be removed. I recall it was used to smooth NSST foundation temperature (tref) as an option to run CHGRES, and/or replace tref with an external dataset. George's new CHGRES_CUBE probably does not need or support this anymore. Not sure if any DA step is still using this program.

[edwardhartnett]

@XuLi-NOAA can you tell us if this program is still needed?

[XuLi-NOAA]

@XuLi-NOAA can you tell us if this program is still needed?

This utility has been extended to do more updates of the tref in the sfc file, it is available for wcoss right now.
However, rarely, it will not be needed, so it can be removed, unless we really want to keep it for possible need in the future.

[edwardhartnett]

@XuLi-NOAA I'm not quite clear on whether we can remove this or not. ;-)

@yangfanglin should we remove this, moving forward? (Of course it is still in the public-v2 release and still in the repo, we're not really removing anything.)

We are doing a test + unit testing campaign on UFS_UTILS. So if we don't need it, that would be great. If we do need it, then we should document and test it.

[yangfanglin]

Ed, I agree you can remove it since it is rarely used. Xu can always use his local copy or the earlier repos if needed. Fanglin

…

On Thu, Feb 25, 2021 at 10:54 AM Edward Hartnett ***@***.***> wrote: @XuLi-NOAA <https://github.com/XuLi-NOAA> I'm not quite clear on whether we can remove this or not. ;-) @yangfanglin <https://github.com/yangfanglin> should we remove this, moving forward? (Of course it is still in the public-v2 release and still in the repo, we're not really removing anything.) We are doing a test + unit testing campaign on UFS_UTILS. So if we don't need it, that would be great. If we do need it, then we should document and test it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#334 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKY5N2OUJPQV4WMS6CCBJ2TTAZXBFANCNFSM4YA73RXQ> .

-- *Fanglin Yang, Ph.D.* *Chief, Model Physics Group* *Modeling and Data Assimilation Branch* *NOAA/NWS/NCEP Environmental Modeling Center* *https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/ <https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>*

[GeorgeGayno-NOAA]

He opened this issue to update the program. #90 The current version does not work with the current GFS.