Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checksum from sfcanl_data.tileX.nc files following global_cycle. #781

Closed
aerorahul opened this issue Feb 27, 2023 · 6 comments · Fixed by #794
Closed

Remove checksum from sfcanl_data.tileX.nc files following global_cycle. #781

aerorahul opened this issue Feb 27, 2023 · 6 comments · Fixed by #794
Assignees

Comments

@aerorahul
Copy link
Contributor

When the sfcanl_data.tileX.nc files are created with the program global_cycle, the checksum global attribute is retained.
This checksum is bound to be incorrect (unless recalculated), when fields are updated.

This is seen when using GFSv16 CCPP SDF. The model fails after global_cycle updates the sfc_data.tileX.nc files to produce sfcanl_data.tileX.nc.

@CoryMartin-NOAA ran into this issue when he tested the cycled global-workflow with the GFSv16 configuration.

A requested solution is to delete the checksum global attribute from the sfcanl_data.tileX.nc files in the utility global_cycle.

The proposal is being tested via: https://github.com/aerorahul/UFS_UTILS/pull/new/feature/checksum

@GeorgeGayno-NOAA
Copy link
Collaborator

Will work this issue under this branch:
https://github.com/GeorgeGayno-NOAA/UFS_UTILS/tree/feature/checksum

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Mar 14, 2023
@GeorgeGayno-NOAA
Copy link
Collaborator

@aerorahul I have logic working that will remove the 'checksum' attribute. Before I go further, should I remove 'checksum' from all records in the file, or only those records that get updated? For NoahMP, I will only update a small subset of the records in the file.

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Mar 17, 2023
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Mar 17, 2023
@GeorgeGayno-NOAA
Copy link
Collaborator

@aerorahul Please try my branch at 2c5ff01, which will remove 'checksum' for all updated records.

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Mar 20, 2023
@aerorahul
Copy link
Contributor Author

Thanks @GeorgeGayno-NOAA. Will give it a try.

@CoryMartin-NOAA
Copy link
Contributor

Looks like this does the trick, an older version of UFS_UTILS causes the forecast to fail due to incorrect checksums, but this commit allows the model to initialize.

@GeorgeGayno-NOAA
Copy link
Collaborator

Looks like this does the trick, an older version of UFS_UTILS causes the forecast to fail due to incorrect checksums, but this commit allows the model to initialize.

Great. I will initiate a PR.

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Mar 24, 2023
GeorgeGayno-NOAA added a commit that referenced this issue Mar 24, 2023
If the input file has the checksum attribute, new logic will remove it
from any record that is updated.

Fixes #781.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants