Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder enkf outputs from gdas_init to align with new global workflow structure #762

Closed
DavidHuber-NOAA opened this issue Jan 26, 2023 · 5 comments · Fixed by #764
Closed
Assignees

Comments

@DavidHuber-NOAA
Copy link
Collaborator

The global workflow gdasenkf directory structure was changed in PR NOAA-EMC/global-workflow#1201 from enkfgdas.YYYYMMDD/CC/atmos/memXXX to enkfgdas.YYYYMMDD/CC/memXXX/atmos. The output structure of gdas_init should be modified to match.

@GeorgeGayno-NOAA
Copy link
Collaborator

@DavidHuber-NOAA This appears to be an easy fix. I can try to work on it today.

@GeorgeGayno-NOAA GeorgeGayno-NOAA self-assigned this Jan 26, 2023
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 26, 2023
@GeorgeGayno-NOAA
Copy link
Collaborator

@DavidHuber-NOAA Can you try my branch at 5d5bc76.

@DavidHuber-NOAA
Copy link
Collaborator Author

@GeorgeGayno-NOAA This works and all outputs are bitwise identical when compared to the current develop branch. Thanks!

@GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA This works and all outputs are bitwise identical when compared to the current develop branch. Thanks!

I will open a PR.

@GeorgeGayno-NOAA
Copy link
Collaborator

As a future improvement, we should try to combine the various chgres run scripts into one so that a change such as this can be made in one place. There may also be a way to combine the driver scipts for each machine. The data pull scripts are very different because the GFS/GDAS tarballs have changed so much over the years. So I don't think the data scripts can be combined.

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Feb 2, 2023
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants