Check for git clone failure in rt.sh

[GeorgeGayno-NOAA]

The rt.sh script is run off the cron on all supported machines. Recently, the script failed during the git clone command on Hera because the machine's disk was full. The log file showed:

Cloning into 'UFS_UTILS'...
error: copy-fd: write returned: Disk quota exceeded
fatal: cannot copy '/usr/share/git-core/templates/hooks/commit-msg.sample' to '/scratch2/NCEPDEV/stmp1/role.ufsutils/reg_tests.cron/UFS_UTILS/.git/hooks/commit-msg.sample': Disk quota exceeded
/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/UFS_UTILS/reg_tests/rt.sh: line 20: cd: UFS_UTILS: No such file or directory
/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/UFS_UTILS/reg_tests/rt.sh: line 22: sorc/machine-setup.sh: No such file or directory
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/UFS_UTILS/reg_tests/rt.sh: line 37: echo: write error: Disk quota exceeded
/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/UFS_UTILS/reg_tests/rt.sh: line 39: ./build_all.sh: No such file or directory
/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/UFS_UTILS/reg_tests/rt.sh: line 52: cd: fix: No such file or directory
/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/UFS_UTILS/reg_tests/rt.sh: line 53: ./link_fixdirs.sh: No such file or directory
/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/UFS_UTILS/reg_tests/rt.sh: line 55: cd: ../reg_tests: No such file or directory
/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/UFS_UTILS/reg_tests/rt.sh: line 84: cd: snow2mdl: No such file or directory
/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/UFS_UTILS/reg_tests/rt.sh: line 85: ./driver..sh: No such file or directory

An email was sent to the maintainers, but the subject line did not indicate the machine, and the body of the email was blank.

The script needs better error handling.

[GeorgeGayno-NOAA]

How to test this logic? The disk has been cleaned up on Hera. So I can't repeat the original problem. All I can do is adjust the script logic to trip the error. Example, look for the wrong directory:

diff --git a/reg_tests/rt.sh b/reg_tests/rt.sh
index e2d975a..b84cfd8 100755
--- a/reg_tests/rt.sh
+++ b/reg_tests/rt.sh
 # Check to see if the clone was successful. Previously, it has
 # failed due to lack of disk space.

-if [[ $rc == 0 ]] && [[ -d UFS_UTILS ]];then
+if [[ $rc == 0 ]] && [[ -d US_UTILS ]];then
   echo "Clone Successful"
 else

Or make the clone fail:

 rm -f reg_test_results.txt
 rm -rf UFS_UTILS

-git clone --recursive https://github.com/ufs-community/UFS_UTILS.git
+git clone --recursive www.github.com/ufs-community/UFS_UTILS.git
 rc=$?

[GeorgeGayno-NOAA]

The error was tripped on Hera, Jet, Orion and WCOSS2. As expected, the script execution stopped and a proper email was sent to my NOAA email account.