Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Compile on 4.24 Preview 1 #246

Closed
grigorovich opened this issue Nov 7, 2019 · 1 comment
Closed

Compile on 4.24 Preview 1 #246

grigorovich opened this issue Nov 7, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@grigorovich
Copy link
Contributor

grigorovich commented Nov 7, 2019

To compile plugin on 4.24 Ive just trim namespace 'UE4StringConv_Private' in file Source/VaRestPlugin/Private/VaRestJsonParser.cpp (line 86):

if (UE4StringConv_Private::IsHighSurrogate(Codepoint) || UE4StringConv_Private::IsLowSurrogate(Codepoint))
to dat
if (StringConv::IsHighSurrogate(Codepoint) || StringConv::IsLowSurrogate(Codepoint)).

UE4StringConv_Private to StringConv

Compiled and works fine with UE 4.24 Preview 1 on macos 10.15.1 and xcode 11.2

@ufna ufna added the enhancement New feature or request label Nov 8, 2019
@ufna
Copy link
Owner

ufna commented Nov 8, 2019

Thanks, @grigorovich , I've moved UE 4.24 support to separate branch until its release.

@ufna ufna closed this as completed Nov 8, 2019
Gathers pushed a commit to Gathers/VaRest that referenced this issue Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants