Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Memory leaks #220

Closed
RyuMaster opened this issue Jun 12, 2019 · 5 comments
Closed

Memory leaks #220

RyuMaster opened this issue Jun 12, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@RyuMaster
Copy link

TCHAR* DestinationBuffer = new TCHAR[DestinationLength];

nevers gets deleted;

Also, in many
UE_LOG functions,

*balabla->SomeString()
produces memory leaks, has to be

FString asas= balabla->SomeString();
UE_LOG(*asas)

@ufna ufna added the bug Something isn't working label Jun 13, 2019
ufna added a commit that referenced this issue Jun 13, 2019
@ufna
Copy link
Owner

ufna commented Jun 13, 2019

Hi @RyuMaster ,

Thanks for pointing this buffer, fixed now.

Regarding UE_LOG, please provide an example. UE_LOG(LogVaRest, Log, TEXT("%s: Request (urlencoded): %s %s (check bExtendedLog for additional data)"), *VA_FUNC_LINE, *HttpRequest->GetVerb(), *HttpRequest->GetURL()); is completely valid, I don't see any leaks here. (also, it widely used in the engine code itself)

@RyuMaster
Copy link
Author

RyuMaster commented Jun 13, 2019

Hi! In regards to UE_LOG, I am no sure, it just reliably produces me memory leak when I am using

#define MALLOC_LEAKDETECTION 1
MallocLeak Start

to test.

but maybe false alarms then? Or could be related to my code, as I am using this inside multhithreading code.

@ufna
Copy link
Owner

ufna commented Jun 13, 2019

Hm, I'll test it today with the same define.

@RyuMaster
Copy link
Author

Righty! I was just following this tutorial for my project:

https://dzone.com/articles/dealing-with-memory-leaks-in-unreal-engine-4

And stumbled upon it

@ufna
Copy link
Owner

ufna commented Jun 13, 2019

@RyuMaster , I've checked it and and seemed okay :)

@ufna ufna closed this as completed Jun 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants