Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle "newline only" strings #159

Merged
merged 5 commits into from
Oct 17, 2023
Merged

handle "newline only" strings #159

merged 5 commits into from
Oct 17, 2023

Conversation

jlgeering
Copy link
Collaborator

@jlgeering jlgeering commented Oct 17, 2023 •
edited
Loading

Fixes #157

I think "\n" deserves a special case as

key: "\n"
next: value

feels prettier than

key: |+

next: value

Requirements

  • Entry in CHANGELOG.md was created
  • Link to documentation on https://yaml.org/ is provided in the PR description
  • Functionality is covered by newly created tests

@github-actions
Copy link

github-actions bot commented Oct 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build f611e17c77fdaf31f206a3e13639616378515530-PR-159

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build d865fb4c61d3199c2ac7d2f2ef98e30b621418c1: 0.0%
Covered Lines: 108
Relevant Lines: 108
💛 - Coveralls

@jlgeering jlgeering mentioned this pull request Oct 17, 2023
Closed
3 tasks
@jlgeering jlgeering force-pushed the newline-only-strings branch from 78318bc to 1d63c31 Compare October 17, 2023 11:49
@jlgeering jlgeering force-pushed the newline-only-strings branch from 53a7a95 to f611e17 Compare October 17, 2023 11:59
@jlgeering jlgeering requested a review from mruoss October 17, 2023 12:39
mruoss
mruoss approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@mruoss mruoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mruoss mruoss merged commit dba4e2c into main Oct 17, 2023
@jlgeering jlgeering deleted the newline-only-strings branch October 20, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruoss mruoss mruoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid output with strings that are only a newline.
2 participants
@jlgeering @mruoss