Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only flake8 check #289

Merged
merged 5 commits into from
Nov 16, 2022
Merged

only flake8 check #289

merged 5 commits into from
Nov 16, 2022

Conversation

Azuki-bar
Copy link
Member

#277 のレビューが重いので時間がかかります。
しかし静的解析は欲しいのでとりあえず静的解析だけ

@n4o847
Copy link
Collaborator

n4o847 commented Nov 16, 2022

分割していただいてありがとうございます!

self.setDia(3, "chofu_up", False, 5, "hashimoto_b2", "chofu_b5")
self.setDia(3, "sakurajosui_up", True, 5, "sakurajosui_b4", "sakurajosui_b6")
self.setDia(3, "shinjuku_up", False, 5, "sakurajosui_b6", "shinjuku_b2")
# 今回は、退避が存在しない。すべての駅で5秒停車させる
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DiaPlanner が戻っちゃっているので直していただきたいです

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

af3fbd9 にて修正しました

Azuki-bar and others added 2 commits November 16, 2022 23:30
Co-authored-by: Yuya Miura <22975590+n4o847@users.noreply.github.com>
@Azuki-bar Azuki-bar requested a review from n4o847 November 16, 2022 14:35
Copy link
Collaborator

@n4o847 n4o847 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました!

@Azuki-bar Azuki-bar merged commit b684703 into main Nov 16, 2022
@Azuki-bar Azuki-bar deleted the enable-flake8 branch November 16, 2022 14:41
@github-actions github-actions bot mentioned this pull request Nov 16, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants