fix: findDuplicates - use Array.from when converting Set #5428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
I was getting a duplicate extension warning in Chrome because the duplicates array would contain an empty Set object:
For whatever reason spreading the Set as a new array isn't always working as intended and causes a false positive regarding duplicates. The issue disappears when using
Array.from
.Implementation Approach
Switch from
[...new Set(filtered)]
toArray.from(new Set(filtered))
Testing Done
I tested this on my local project. It's pretty straightforward change, so didn't overthink testing here.
Verification Steps
Ensure that the duplicate extension warning is not being logged.
Checklist