fix: allow task items to be parsed when only having <li data-checked instead of only when <li data-checked="true" (re-fix of #5366)

[baseballyama]

Changes Overview

When I modified the code in response to the comments in PR #5366, somehow I made the wrong modification. I am very sorry.🙏🙏🙏 @nperez0111

This PR will be correctly amended according to this comment.
I have confirmed that it works correctly with both the REPL created in #5366 and my own product code.

I will take care to avoid similar carelessness.🙏

Implementation Approach

Testing Done

I tested it by manual.

Verification Steps

Additional Notes

Checklist

• I have created a changeset for this PR if necessary.
• My changes do not break the library.
• I have added tests where applicable.
• I have followed the project guidelines.
• I have fixed any lint issues.

Related Issues

#5366

[changeset-bot]

🦋 Changeset detected

Latest commit: a0c9725

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages

Name	Type
@tiptap/extension-task-item	Patch
@tiptap/core	Patch
@tiptap/extension-blockquote	Patch
@tiptap/extension-bold	Patch
@tiptap/extension-bubble-menu	Patch
@tiptap/extension-bullet-list	Patch
@tiptap/extension-character-count	Patch
@tiptap/extension-code-block-lowlight	Patch
@tiptap/extension-code-block	Patch
@tiptap/extension-code	Patch
@tiptap/extension-collaboration-cursor	Patch
@tiptap/extension-collaboration	Patch
@tiptap/extension-color	Patch
@tiptap/extension-document	Patch
@tiptap/extension-dropcursor	Patch
@tiptap/extension-floating-menu	Patch
@tiptap/extension-focus	Patch
@tiptap/extension-font-family	Patch
@tiptap/extension-gapcursor	Patch
@tiptap/extension-hard-break	Patch
@tiptap/extension-heading	Patch
@tiptap/extension-highlight	Patch
@tiptap/extension-history	Patch
@tiptap/extension-horizontal-rule	Patch
@tiptap/extension-image	Patch
@tiptap/extension-italic	Patch
@tiptap/extension-link	Patch
@tiptap/extension-list-item	Patch
@tiptap/extension-list-keymap	Patch
@tiptap/extension-mention	Patch
@tiptap/extension-ordered-list	Patch
@tiptap/extension-paragraph	Patch
@tiptap/extension-placeholder	Patch
@tiptap/extension-strike	Patch
@tiptap/extension-subscript	Patch
@tiptap/extension-superscript	Patch
@tiptap/extension-table-cell	Patch
@tiptap/extension-table-header	Patch
@tiptap/extension-table-row	Patch
@tiptap/extension-table	Patch
@tiptap/extension-task-list	Patch
@tiptap/extension-text-align	Patch
@tiptap/extension-text-style	Patch
@tiptap/extension-text	Patch
@tiptap/extension-typography	Patch
@tiptap/extension-underline	Patch
@tiptap/extension-youtube	Patch
@tiptap/html	Patch
@tiptap/pm	Patch
@tiptap/react	Patch
@tiptap/starter-kit	Patch
@tiptap/suggestion	Patch
@tiptap/vue-2	Patch
@tiptap/vue-3	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for tiptap-embed ready!

Name	Link
🔨 Latest commit	a0c9725
🔍 Latest deploy log	https://app.netlify.com/sites/tiptap-embed/deploys/66aa459459cf33000808b2fd
😎 Deploy Preview	https://deploy-preview-5426--tiptap-embed.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[baseballyama]

@bdbch

Did you force pushed some commit to https://github.com/baseballyama/tiptap/commits/develop/ ? (This is my forked repo)

Maybe did you intend to push it to ueberdosis:develop?

[bdbch]

LGTM - just not sure if we need the null check or not.

[bdbch]

Should we still keep the null check here?

return dataChecked === null || dataChecked === '' || dataChecked === 'true'

[baseballyama]

No I believe we shouldn't.

Case1: <li>, dataChecked will be null,
Case2: <li data-checked>, dataChecked will be '',
Case3: <li data-checked="true">, dataChecked will be 'true',
Case3: <li data-checked="false">, dataChecked will be 'false',

Case1 and case4, checked attribute should be recognize as false,
Case 2 and case3, checked attribute should be recognize as true,

[bdbch]

@baseballyama I force pushed on our develop to move the commit you mentioned over to next.

You probably have to rebase your branch to the current develop here.

[baseballyama]

I force pushed on our develop to move the commit you mentioned over to next.
You probably have to rebase your branch to the current develop here.

Understood.
I think current diff is looks fine.

develop...baseballyama:fix/5366