Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making default value as javascript from auto #5404

Closed
wants to merge 1 commit into from

Conversation

parthiv360
Copy link

@parthiv360 parthiv360 commented Jul 28, 2024

Changes Overview

Issue: #5307

Implementation Approach

They have been rendering auto in the null value for now. Changing the default value to javascript wont help us as auto was hard coded. So I changed that to javascript

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Copy link

changeset-bot bot commented Jul 28, 2024

⚠️ No Changeset found

Latest commit: 0550b63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jul 28, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 0550b63
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66a5f53d51b7ba0008834141
😎 Deploy Preview https://deploy-preview-5404--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@AbhayVAshokan AbhayVAshokan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parthiv360 You have modified the demos folder to make javascript as the default language. This change does not impact the extension-code-block-lowlight package, and hence it does not solve the issue itself. Please revert these two changes.

The issue discusses how the defaultLanguage prop is not functional.

@parthiv360
Copy link
Author

Okay , I will make necessary changes.

@nperez0111
Copy link
Contributor

Closing in favor of #5406

@nperez0111 nperez0111 closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants