Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): make exitable resolve it's value through inheritance #5244

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix(core): make exitable resolve it's value through inheritance #5244

merged 1 commit into from
Jun 18, 2024

Conversation

nperez0111
Copy link
Contributor

@nperez0111 nperez0111 commented Jun 18, 2024 •
edited
Loading

Changes Overview

Pull the exitable value from the correct place
#4191 (comment)

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have renamed my PR according to the naming conventions. (e.g. feat: Implement new feature or chore(deps): Update dependencies)
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

@netlify Netlify
Copy link

netlify bot commented Jun 18, 2024 •
edited
Loading

✅ Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit e896c05
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/667105a3160fe700080d4f27
😎 Deploy Preview https://deploy-preview-5244--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nperez0111 nperez0111 merged commit 2ef43e9 into develop Jun 18, 2024
14 checks passed
@nperez0111 nperez0111 deleted the nick/exitable branch June 18, 2024 04:07
@nperez0111 nperez0111 mentioned this pull request Jul 13, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdbch bdbch Awaiting requested review from bdbch bdbch is a code owner

@svenadlung svenadlung Awaiting requested review from svenadlung svenadlung is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Tiptap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nperez0111