Pass onFirstRender option to ySyncPlugin #4530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
here is an option called `onFirstRender` in the `CollaborationOptions` type; however, it is not used anywhere. This commit passes the option to the Yjs' sync plugin.
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
svenadlung
approved these changes
Oct 12, 2023
|
LGTM, thx @furkan3ayraktar |
bdbch
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
There is an option called
onFirstRenderin theCollaborationOptionstype; however, it is not used anywhere. This commit passes the option to the Yjs' sync plugin.We use this callback together with the HocuspocusProvider to understand when the content is synced and ready on the editor for the first time. Then, we can safely set the cursor to the beginning of the text editor.
How did you accomplish your changes
Just used the existing option and correctly passed it to the
ySyncPluginfunction that creates the plugin.How can we verify your changes
You can pass
onFirstRenderoption to the Collaboration extension and see it gets called when the plugin first renders.Checklist