allow users to pass a custom findSuggestionMatch to Suggestion plugin
#4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Looks good to me. Thank you so much for your contribution @estrattonbailey. I think we could add the new prop to the docs as well: https://tiptap.dev/api/utilities/suggestion Btw: I just see that the |
|
Thanks for the quick review! I added to the docs, feel free to edit. I'm not 100% on what |
|
Hey @svenadlung 👋 just wanted to bump this in case it got lost in the shuffle 😄 |
|
Awesome, thx. LGTM. |
svenadlung
approved these changes
Oct 19, 2023
|
Hey @svenadlung 👋 no particular rush on my end, but any chance we can get this merged and released soon-ish? Thanks for your help! |
|
Hey @svenadlung just bumping this again :) thanks! |
janthurau
force-pushed
the
allow-custom-suggestion-matching
branch
from
8b0c991
to
76b8a29
Compare
janthurau
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Hey there 👋 we're using Tiptap and the Suggestions plugin to implement hashtags in our editor. Our hashtag validation is a little more complex than what the default
findSuggestionMatchallows, so I started investigating how I could replace the matching with a custom version. This seemed to be the most straightforward approach.Disclaimer: this might be more of a conversation starter than a fix, but fwiw it does work for my needs right now. Happy to help improve.
How did you accomplish your changes
Just added a new property
findSuggestionMatchto theSuggestionplugin, with types that match the built-in function.How have you tested your changes
Just manually integrating at the moment, but lmk if I can assist with a test suite.
How can we verify your changes
I think it's straightforward.
Checklist
Related issues
N/A