Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link click fix #4423

Merged
merged 4 commits into from
Nov 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions demos/src/Marks/Link/React/index.jsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import './styles.scss'

import Bold from '@tiptap/extension-bold'
import Code from '@tiptap/extension-code'
import Document from '@tiptap/extension-document'
import Link from '@tiptap/extension-link'
Expand All @@ -15,13 +16,14 @@ export default () => {
Paragraph,
Text,
Code,
Bold,
Link.configure({
openOnClick: false,
openOnClick: true,
}),
],
content: `
<p>
Wow, this editor has support for links to the whole <a href="https://en.wikipedia.org/wiki/World_Wide_Web">world wide web</a>. We tested a lot of URLs and I think you can add *every URL* you want. Isn’t that cool? Let’s try <a href="https://statamic.com/">another one!</a> Yep, seems to work.
Wow, this editor has support for links to the whole <a href="https://en.wikipedia.org/wiki/World_Wide_Web"><b>world wide web</b></a>. We tested a lot of URLs and I think you can add *every URL* you want. Isn’t that cool? Let’s try <a href="https://statamic.com/">another one!</a> Yep, seems to work.
</p>
<p>
By default every link will get a <code>rel="noopener noreferrer nofollow"</code> attribute. It’s configurable though.
Expand Down
14 changes: 9 additions & 5 deletions packages/extension-link/src/helpers/clickHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,15 @@ export function clickHandler(options: ClickHandlerOptions): Plugin {
return false
}

const eventTarget = event.target as HTMLElement
let a = event.target as HTMLElement
const els = []

if (eventTarget.nodeName !== 'A') {
while (a.nodeName !== 'DIV') {
els.push(a)
a = a.parentNode as HTMLElement
}

if (!els.find(value => value.nodeName === 'A')) {
return false
}

Expand All @@ -28,9 +34,7 @@ export function clickHandler(options: ClickHandlerOptions): Plugin {
const target = link?.target ?? attrs.target

if (link && href) {
if (view.editable) {
window.open(href, target)
}
window.open(href, target)

return true
}
Expand Down