Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(link): allow to unset target attribute #3425

Merged
merged 1 commit into from
Nov 25, 2022
Merged

fix(link): allow to unset target attribute #3425

merged 1 commit into from
Nov 25, 2022

Conversation

dargmuesli
Copy link
Contributor

Resolves #3276.

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 9ce54d8
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/6376c4e86117da0009298ca7
😎 Deploy Preview https://deploy-preview-3425--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdbch bdbch merged commit 1c3568d into ueberdosis:main Nov 25, 2022
@dargmuesli
Copy link
Contributor Author

@bdbch thank you for merging this! Seems like there was a problem with the merge's build though and the fix was not released.

@dargmuesli dargmuesli deleted the patch-1 branch November 25, 2022 18:26
@bdbch
Copy link
Contributor

bdbch commented Nov 25, 2022

Hey @dargmuesli - we have a few problems with our tests being capped by Github Actions. We're currently looking into potential solutions.

Your merge will be released with the next release. We do releases manually so not every merged commit is automatically released right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link Extension, always adding target="_blank" when instatiating editor.
2 participants