fix(core): dont use selection for setContent replacement #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
2 tasks
EvitanRelta
added a commit
to EvitanRelta/markgh
that referenced
this pull request
Jul 12, 2022
Fixes partially #58, from the recent ueberdosis/tiptap#2934 PR fix that has been published in '@tiptap/core@2.0.0-beta.182'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2846
prosemirror added a new warning when a selection is created that is not pointing into an inline node. This PR is fixing that warning on
commands.setContentvia not using a new Selection replacement but just replacing the current documents content from0todocument.content.sizewith the new Document created.