Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only trigger image input rule at the start or with a preceding space #2830

Merged
merged 1 commit into from
May 27, 2022

Conversation

rfgamaral
Copy link
Contributor

This only allows the image input rule to be triggered:

  • At the start of a paragraph/line
  • If it has a preceding space

This prevents the rule from triggering when one is typing the image Markdown syntax inside an inline code mark.

Before

firefox_hz7MRH4sg0.mp4

After

firefox_1WVMJWYzcv.mp4

@netlify
Copy link

netlify bot commented May 26, 2022

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 66019df
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/628fa32fb26a86000bc63b1b
😎 Deploy Preview https://deploy-preview-2830--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdbch bdbch merged commit 5fef431 into ueberdosis:main May 27, 2022
@bdbch
Copy link
Member

bdbch commented May 27, 2022

Awesome, thanks!

@rfgamaral rfgamaral deleted the ricardo/fix-image-input-rule branch May 27, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants