Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extendMarkRange doesn't work when cursor is at end of mark, despite isActive() returning true for that mark #2717

Merged
merged 2 commits into from
May 17, 2022
Merged

fix: extendMarkRange doesn't work when cursor is at end of mark, despite isActive() returning true for that mark #2717

merged 2 commits into from
May 17, 2022

Conversation

JDinABox
Copy link
Contributor

Fixes #2535

@netlify
Copy link

netlify bot commented Apr 17, 2022 •
edited
Loading

✅ Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 8984f49
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/62670d7a5cca57000a62d294
😎 Deploy Preview https://deploy-preview-2717--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdbch
Copy link
Member

bdbch commented May 17, 2022

Thanks for your PR!

@bdbch bdbch merged commit 0fb68af into ueberdosis:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdbch bdbch bdbch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extendMarkRange doesn't work when cursor is at end of mark, despite isActive() returning true for that mark
2 participants
@JDinABox @bdbch