fix: don't override behaviour of Home / End in pc keymap #2691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2685 by removing the Home/End keybindings in the PC keymap.
This was similarly removed in Prosemirror at ProseMirror/prosemirror-commands@20371c58, to favour default browser / OS behaviour.
Note: This behaviour continues to be preserved on Mac under the
Ctrl-a
andCtrl-e
keysFor users who wish to preserve this behaviour, they can achieve this via a custom extension:
If we haven't reached consensus on this change, then feel free to ignore. Just raising the PR in case this is all that's missing to resolve the issue.