Add key bindings for uppercase letters for bold, italic and underline #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, key bindings 'Mod-B', 'Mod-I' and 'Mod-U' with active caps lock have the same effect as their lowercase siblings. Prosemirror examples did the same, see ProseMirror/prosemirror#895 Fixes: ueberdosis#2426 Signed-off-by: Jonas <jonas@freesources.org>
|
✔️ Deploy Preview for tiptap-embed ready! 🔨 Explore the source changes: 5bce4af 🔍 Inspect the deploy log: https://app.netlify.com/sites/tiptap-embed/deploys/61fbc48d2eaeb2000759635b 😎 Browse the preview: https://deploy-preview-2478--tiptap-embed.netlify.app |
mejo-
added a commit
to nextcloud/text
that referenced
this pull request
Feb 3, 2022
This way, key bindings 'Mod-B', 'Mod-I' and 'Mod-U' with active caps lock have the same effect as their lowercase siblings. This is supposed to be fixed in Tiptap v2 upstream: ueberdosis/tiptap#2426 ueberdosis/tiptap#2478 Fixes: #2050 Signed-off-by: Jonas <jonas@freesources.org>
|
Seems like the failing Cypress tests in CI are unrelated - at least they also fail on latest master 🤔 |
mejo-
added a commit
to nextcloud/text
that referenced
this pull request
Feb 3, 2022
This way, key bindings 'Mod-B', 'Mod-I' and 'Mod-U' with active caps lock have the same effect as their lowercase siblings. This is supposed to be fixed in Tiptap v2 upstream: ueberdosis/tiptap#2426 ueberdosis/tiptap#2478 Fixes: #2050 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
to nextcloud/text
that referenced
this pull request
Feb 3, 2022
This way, key bindings 'Mod-B', 'Mod-I' and 'Mod-U' with active caps lock have the same effect as their lowercase siblings. This is supposed to be fixed in Tiptap v2 upstream: ueberdosis/tiptap#2426 ueberdosis/tiptap#2478 Fixes: #2050 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
to nextcloud/text
that referenced
this pull request
Feb 3, 2022
This way, key bindings 'Mod-B', 'Mod-I' and 'Mod-U' with active caps lock have the same effect as their lowercase siblings. This is supposed to be fixed in Tiptap v2 upstream: ueberdosis/tiptap#2426 ueberdosis/tiptap#2478 Fixes: #2050 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
to nextcloud/text
that referenced
this pull request
Feb 3, 2022
This way, key bindings 'Mod-B', 'Mod-I' and 'Mod-U' with active caps lock have the same effect as their lowercase siblings. This is supposed to be fixed in Tiptap v2 upstream: ueberdosis/tiptap#2426 ueberdosis/tiptap#2478 Fixes: #2050 Signed-off-by: Jonas <jonas@freesources.org>
|
Thanks! (Yeah, tests are broken right now 🥴) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, key bindings 'Mod-B', 'Mod-I' and 'Mod-U' with active caps
lock have the same effect as their lowercase siblings.
Prosemirror examples did the same, see ProseMirror/prosemirror#895
Fixes: #2426
Signed-off-by: Jonas jonas@freesources.org