Add option to allow task items to be checkable (uncontrolled)

[kaspnilsson]

Useful for drafting interactive documents. Could see this expanding to potentially also support passing a callback?

Will happily update documentation if this approach is accepted!

[netlify]

👷 Deploy request for tiptap-embed pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	565f29a

[philippkuehn]

Hey, thanks!

I’m happy to accept a checkable callback method to implement custom behavior here. But this should also control if the command is executed to update the checked attribute so this could be a fix for #2144 too.

An update for the docs would be great too ✌️

[bkempe]

I think this could be achieved via:

        if (!editor.isEditable && onReadOnlyChecked) {
          onReadOnlyChecked(node, checked);
        }

after

if (editor.isEditable && typeof getPos === 'function') { ... }

[kaspnilsson]

Think I did what y'all requested, let me know if this works @philippkuehn @bkempe!

[kaspnilsson]

Ping @philippkuehn @bkempe

[bkempe]

@kaspnilsson It's not up to me to approve, but it looks great :)

[bkempe]

@kaspnilsson One thing that might be nice: revert the change if onReadOnlyChecked returns false?

[bdbch]

Hey @kaspnilsson - looks nice! I think we have some linting issues. Could you resolve them? I'll make sure to take a look again when you're done so we can get your work merged! 👍

[kaspnilsson]

@bdbch done!

[bdbch]

Just a question about the dependencies. Otherwise looks good.