Mark @tiptap/react
and @tiptap/core
as side effect free
#2361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tiptap people! 👋
I created a PR directly instead of an issue because the diff is quite small. Feel free to close this if undesired. 😊
As far as I understand, Tiptap doesn't rely on global side effects anywhere within the packages
@tiptap/core
and@tiptap/react
(I didn't check the other packages). I addedsideEffects: false
to both package.jsons to indicate to app bundlers (primarily webpack and rollup) that unused exports within those packages can be removed safely from the final bundle. That's especially useful for large packages like@tiptap/react
and@tiptap/core
.More info: https://webpack.js.org/guides/tree-shaking