Mark @tiptap/react and @tiptap/core as side effect free
#2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for tiptap-embed ready! 🔨 Explore the source changes: 47b6ddc 🔍 Inspect the deploy log: https://app.netlify.com/sites/tiptap-embed/deploys/61d813b874608500079f498a 😎 Browse the preview: https://deploy-preview-2361--tiptap-embed.netlify.app |
dcastil
changed the title
@tiptap/react and @tiptap/core as side effect free
|
Thanks! Yeah I think we can do this. |
|
@philippkuehn Let me know whether I should check the other packages as well and add the change there, too. 😊 |
|
I’ve also added it to the Vue packages ✌️ |
andrewlu0
pushed a commit
to trybaseplate/tiptap
that referenced
this pull request
Oct 20, 2023
…erdosis#2361) * Update package.json * Update package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tiptap people! 👋
I created a PR directly instead of an issue because the diff is quite small. Feel free to close this if undesired. 😊
As far as I understand, Tiptap doesn't rely on global side effects anywhere within the packages
@tiptap/coreand@tiptap/react(I didn't check the other packages). I addedsideEffects: falseto both package.jsons to indicate to app bundlers (primarily webpack and rollup) that unused exports within those packages can be removed safely from the final bundle. That's especially useful for large packages like@tiptap/reactand@tiptap/core.More info: https://webpack.js.org/guides/tree-shaking