Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using vue 2 and 3 when passing props to VueRenderer in Mention plugin #2319

Merged
merged 1 commit into from
Dec 27, 2021
Merged

Using vue 2 and 3 when passing props to VueRenderer in Mention plugin #2319

merged 1 commit into from
Dec 27, 2021

Conversation

domstrueboy
Copy link
Contributor

A comment clarifying the difference between using vue 2 and 3 when passing props to VueRenderer in Mention plugin
A reason - it tooks me hours to realize that I need not only use this:

parent: this,
propsData: props,

for vue 2 but remove that as well:

props,
editor: props.editor,

It led to a performance issue - a tab freezed in my case when adding some mentions

@netlify
Copy link

netlify bot commented Dec 27, 2021

✔️ Deploy Preview for tiptap-embed ready!

🔨 Explore the source changes: 9d6cce6

🔍 Inspect the deploy log: https://app.netlify.com/sites/tiptap-embed/deploys/61c9807fa386570008d9c42b

😎 Browse the preview: https://deploy-preview-2319--tiptap-embed.netlify.app

@hanspagel hanspagel merged commit 0312fe4 into ueberdosis:main Dec 27, 2021
@hanspagel
Copy link
Contributor

Thanks! 🙌

@domstrueboy domstrueboy deleted the demos/comment-to-explain-using-vue2 branch December 27, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants