-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for autolink #2226
Add support for autolink #2226
Conversation
✔️ Deploy Preview for tiptap-embed ready! 🔨 Explore the source changes: 42cda78 🔍 Inspect the deploy log: https://app.netlify.com/sites/tiptap-embed/deploys/61a94a101eb67623ac886c2f 😎 Browse the preview: https://deploy-preview-2226--tiptap-embed.netlify.app |
I think the default should be |
@rfgamaral Yes definitely! I’m using linkifyjs and there is an open issue for that. But it’s already fixed in v4. Not sure about a release date. |
Amazing work @philippkuehn! Not sure about the https thing! Servers typically redirect http to https, but sites without https can’t redirect to http. So http is probably a better default. Any feedback on the implementation @maccman? |
@hanspagel good point! |
# Conflicts: # packages/extension-link/src/link.ts
# Conflicts: # packages/extension-link/package.json
A better default, but one that enables a less secure Web. @philippkuehn I know it's not possible right now (without linkifyjs v4), but once it's possible, how easy would it be to allow the link extension to have the |
Yes, that should be possible. |
Is the autolink feature still present in latest releases? I'm unable to create links while typing unless theres a whitespace followed by the url. Is this an expected behaviour? |
This PR adds an option
autolink
to the link mark (enabled by default). It lets you automatically add or remove links as you type.Features:
tiptap.dev
get a correct url →http://tiptap.dev
humans@tiptap.dev
get a correct url →mailto:humans@tiptap.dev
tiptap .dev
fixes #1209
preview: https://deploy-preview-2226--tiptap-embed.netlify.app/preview/Marks/Link