initialize autofocus selection in createView
#2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for tiptap-embed ready! 🔨 Explore the source changes: eeae323 🔍 Inspect the deploy log: https://app.netlify.com/sites/tiptap-embed/deploys/61a89478e19aed0008273414 😎 Browse the preview: https://deploy-preview-2212--tiptap-embed.netlify.app |
|
Great, but would be great if you can fix these linting errors! ✌️ |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the initial selection because it is undefined in
EditorState.createis equal toSelection.atStart.Expected behavior is that if
autofocusis defined, it is equal to the selection created on first focus.Example use-case is if
autofocus='end', then within a ProseMirror plugininitmethod:state.doc.selectionshould equalSelection.atEndinstead ofSelection.atStart.